From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
barebox@lists.infradead.org, Roland Hieber <rhi@pengutronix.de>
Subject: Re: [PATCH v3 4/6] clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only
Date: Mon, 5 Aug 2019 12:22:49 +0200 [thread overview]
Message-ID: <20190805102249.dvmg3emz5xrndsq5@pengutronix.de> (raw)
In-Reply-To: <9efd3017-ce12-3e36-6ed3-41db8aa163ce@pengutronix.de>
On Thu, Jul 18, 2019 at 10:25:05AM +0200, Ahmad Fatoum wrote:
> Hello Roland,
>
> On 18/7/19 10:19, Roland Hieber wrote:
> > On Wed, Jul 17, 2019 at 07:06:02PM +0200, Ahmad Fatoum wrote:
> >> From: Philipp Zabel <p.zabel@pengutronix.de>
> >>
> >> Due to incorrect placement of the clock gate cell in the ldb_di[x]_clk
> >> tree, the glitchy parent mux of ldb_di[x]_clk can cause a glitch to
> >> enter the ldb_di_ipu_div divider. If the divider gets locked up, no
> >> ldb_di[x]_clk is generated, and the LVDS display will hang when the
> >> ipu_di_clk is sourced from ldb_di_clk.
> >>
> >> To fix the problem, both the new and current parent of the ldb_di_clk
> >> should be disabled before the switch. As this can not be guaranteed by
> >> the clock framework during runtime, make the ldb_di[x]_sel muxes read-only.
> >> A workaround to set the muxes once during boot could be added to the
> >> kernel or bootloader.
> >>
> >> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> >> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> >> [afa: reviewed for barebox]
> >> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> >> Tested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> >> [afa: ported from Linux kernel commit 03d576f202]
> >
> > Should this line be further above, or were the lines above all part of
> > the Linux commit?
>
> The first [afa: is the Demarcation line between kernel and barebox
> commit message. If I moved the second [afa: further up it wouldn't be
> that clear who did what..
>
> In retrospect, I should have used some ASCII box for the original
> commit and indented it a bit.
Added that and applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-08-05 10:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 17:05 [PATCH v3 0/6] clk: imx6: work around LDB hang caused by ERR009219 Ahmad Fatoum
2019-07-17 17:05 ` [PATCH v3 1/6] clk: imx6: fix use of cpu_is_mx6* before they are initialized Ahmad Fatoum
2019-07-17 17:10 ` Ahmad Fatoum
2019-07-18 15:51 ` Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 2/6] clk: imx6: Mask mmdc_ch1 handshake for periph2_sel and mmdc_ch1_axi_podf Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 3/6] clk: imx6: remove quirky clk_set_parent(LDB_diN_sel, pll5_video_div) Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 4/6] clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only Ahmad Fatoum
2019-07-18 8:19 ` Roland Hieber
2019-07-18 8:25 ` Ahmad Fatoum
2019-07-18 8:33 ` Roland Hieber
2019-08-05 10:22 ` Sascha Hauer [this message]
2019-07-17 17:06 ` [PATCH v3 5/6] clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK Ahmad Fatoum
2019-09-10 13:15 ` Sascha Hauer
2019-09-10 14:07 ` Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 6/6] clk: imx6: define an enum for ldb mux inputs Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805102249.dvmg3emz5xrndsq5@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox