mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: nand: mxs: sync page_size information
Date: Thu, 8 Aug 2019 15:03:07 +0200	[thread overview]
Message-ID: <20190808130307.5zyfhah23xurwxlq@pengutronix.de> (raw)
In-Reply-To: <20190805101731.zskslrcxvrn4nsnp@pengutronix.de>

Hi Sascha,

On 19-08-05 12:17, Sascha Hauer wrote:
> Hi Marco,
> 
> On Fri, Jul 26, 2019 at 11:34:00AM +0200, Marco Felsch wrote:
> > Since commit 51061a9884a3 ("mtd: nand: nand_mxs: Add subpage read
> > support") the ecc_read_page and ecc_write_page page_size can be differ
> > if the calculation is not writesize+oobsize. So during write more bytes
> > are passed trough the bch than during the read operation.
> > 
> > It seems that there are no problems for typical nand flashes using the
> > "normal" layout e.g. 2048+64 (user+oob) but if it gets a bit atypical
> > e.g. 2048+128 (user+oob) this leads into ecc errors.
> 
> What problems did you see exactly? I am using boards here with 2k/128b
> page size and they seem to work properly, also when interacting with Linux.

You are right, the problem was caused by a kernel bug.. which is fixed
now.

Anyway IMHO it seems to be right to write as many bytes as are read. So
do you will accept the patches if I adapt the commit message(s).

Regards,
  Marco

> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-08-08 13:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-26  9:33 [PATCH 1/2] mtd: nand: mxs: add helper to calculate the page size Marco Felsch
2019-07-26  9:34 ` [PATCH 2/2] mtd: nand: mxs: sync page_size information Marco Felsch
2019-08-05 10:17   ` Sascha Hauer
2019-08-08 13:03     ` Marco Felsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190808130307.5zyfhah23xurwxlq@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox