From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 1/5] nvmem: Use helper variable in nvmem_register_cdev()
Date: Mon, 12 Aug 2019 13:19:11 -0700 [thread overview]
Message-ID: <20190812201915.12414-1-andrew.smirnov@gmail.com> (raw)
Add struct cdev * helper variable to nvmem_register_cdev() in order to
avoid repeating &nvmem->cdev a bunch of times
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/nvmem/core.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 6cf98f62af..092e3b4f4a 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -90,16 +90,17 @@ static struct cdev_operations nvmem_chrdev_ops = {
static int nvmem_register_cdev(struct nvmem_device *nvmem, const char *name)
{
struct device_d *dev = &nvmem->dev;
+ struct cdev *cdev = &nvmem->cdev;
const char *alias;
alias = of_alias_get(dev->device_node);
- nvmem->cdev.name = xstrdup(alias ?: name);
- nvmem->cdev.ops = &nvmem_chrdev_ops;
- nvmem->cdev.dev = &nvmem->dev;
- nvmem->cdev.size = nvmem->size;
+ cdev->name = xstrdup(alias ?: name);
+ cdev->ops = &nvmem_chrdev_ops;
+ cdev->dev = &nvmem->dev;
+ cdev->size = nvmem->size;
- return devfs_create(&nvmem->cdev);
+ return devfs_create(cdev);
}
static struct nvmem_device *of_nvmem_find(struct device_node *nvmem_np)
--
2.21.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2019-08-12 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 20:19 Andrey Smirnov [this message]
2019-08-12 20:19 ` [PATCH 2/5] nvmem: Use already existing dev pointer " Andrey Smirnov
2019-08-12 20:19 ` [PATCH 3/5] nvmem: Parse partitions information Andrey Smirnov
2019-08-12 20:19 ` [PATCH 4/5] eeprom: at24: Drop at24_cdev_protect() Andrey Smirnov
2019-08-12 20:19 ` [PATCH 5/5] eeprom: at24: Convert the driver to NVMEM Andrey Smirnov
2019-09-05 22:38 ` Antony Pavlov
2019-09-06 5:23 ` Andrey Smirnov
2019-08-16 11:43 ` [PATCH 1/5] nvmem: Use helper variable in nvmem_register_cdev() Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812201915.12414-1-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox