mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <ahmad@a3f.at>
To: barebox@lists.infradead.org
Cc: afa@pengutronix.de
Subject: [PATCH 09/11] commands: mmc_extcsd: describe missing bit
Date: Thu, 22 Aug 2019 07:51:12 +0200	[thread overview]
Message-ID: <20190822055114.931-10-ahmad@a3f.at> (raw)
In-Reply-To: <20190822055114.931-1-ahmad@a3f.at>

The EXT_CSD_EXCEPTION_EVENTS_STATUS array entry is wrongly duplicated.
Replace the index by the correct field at byte offset 58[1].

[1]: See http://webshop.atlantiksysteme.de/temp/FLEXXONeMMC4.5pSLCSPECV1.2.pdf

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 commands/mmc_extcsd.c | 11 +++++++++--
 include/mci.h         |  1 +
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/commands/mmc_extcsd.c b/commands/mmc_extcsd.c
index c27bb722ea51..ad8e9ad19f5f 100644
--- a/commands/mmc_extcsd.c
+++ b/commands/mmc_extcsd.c
@@ -222,8 +222,8 @@ static struct extcsd_reg extcsd[] = {
                 .access = ACC_R,
                 .width = 2,
         },
-        [EXT_CSD_EXCEPTION_EVENTS_STATUS] = {
-                .name = "EXT_CSD_EXCEPTION_EVENTS_STATUS",
+        [EXT_CSD_EXCEPTION_DYNCAP_NEEDED] = {
+                .name = "EXT_CSD_EXCEPTION_DYNCAP_NEEDED",
                 .access = ACC_R,
                 .width = 1,
         },
@@ -1833,6 +1833,13 @@ static int print_field(u8 *reg, int index)
 		printf("\t[4] EXTENDED_SECURITY_FAILURE: %i\n", val);
 		return 1;
 
+	case EXT_CSD_EXCEPTION_DYNCAP_NEEDED:
+		if  (get_field_val(EXT_CSD_EXCEPTION_EVENTS_STATUS, 2, 0x1)) {
+			val = get_field_val(EXT_CSD_EXCEPTION_DYNCAP_NEEDED, 0, 0x1);
+			printf("\t[0] DYNCAP_NEEDED: %i\n", val);
+		}
+                return 1;
+
 	case EXT_CSD_EXCEPTION_EVENTS_CTRL:
 		val = get_field_val(EXT_CSD_EXCEPTION_EVENTS_CTRL, 1, 0x1);
 		printf("\t[1] DYNCAP_EVENT_EN: %i\n", val);
diff --git a/include/mci.h b/include/mci.h
index 072008ef9da7..77625ea8e901 100644
--- a/include/mci.h
+++ b/include/mci.h
@@ -164,6 +164,7 @@
 #define EXT_CSD_EXT_PARTITIONS_ATTRIBUTE	52	/* R/W, 2 bytes */
 #define EXT_CSD_EXCEPTION_EVENTS_STATUS		54	/* RO, 2 bytes */
 #define EXT_CSD_EXCEPTION_EVENTS_CTRL		56	/* R/W, 2 bytes */
+#define EXT_CSD_EXCEPTION_DYNCAP_NEEDED		58	/* RO, 1 byte */
 #define EXT_CSD_CLASS_6_CTRL			59	/* R/W */
 #define EXT_CSD_INI_TIMEOUT_EMU			60	/* RO */
 #define EXT_CSD_DATA_SECTOR_SIZE		61	/* RO */
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2019-08-22  5:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22  5:51 [PATCH 00/11] treewide: fix some ARCH=arm clang warnings Ahmad Fatoum
2019-08-22  5:51 ` [PATCH 01/11] linux/kbuild.h: sync with upstream Ahmad Fatoum
2019-08-26 10:35   ` Sascha Hauer
2019-09-09  9:57     ` Ahmad Fatoum
2019-08-22  5:51 ` [PATCH 02/11] ratp: fix use of %hu for printing int Ahmad Fatoum
2019-08-22  5:51 ` [PATCH 03/11] complete: remove unused variable Ahmad Fatoum
2019-08-22  6:08   ` Michael Olbrich
2019-08-22  6:22     ` Ahmad Fatoum
2019-08-22  6:32   ` [PATCH 1/2] fixup! " Ahmad Fatoum
2019-08-22  6:32     ` [PATCH 2/2] ata: fix mismatched header guards Ahmad Fatoum
2019-08-22  5:51 ` [PATCH 04/11] i2c-mux-pca954x: remove use of uninitialized variable Ahmad Fatoum
2019-08-22  5:51 ` [PATCH 05/11] net: phy: mv88e6xxx: remove duplicate member in struct initializer Ahmad Fatoum
2019-08-22  5:51 ` [PATCH 06/11] smc911x: fix inverted poll-for-ready Ahmad Fatoum
2019-08-22  5:51 ` [PATCH 07/11] nvme: use 64 bit types for timeouts even on 32 bit systems Ahmad Fatoum
2019-08-22  5:51 ` [PATCH 08/11] usb: gadget: fsl_udc: remove always-true null pointer checks Ahmad Fatoum
2019-08-22  5:51 ` Ahmad Fatoum [this message]
2019-08-22  5:51 ` [PATCH 10/11] gui: png_lode: fix freeing of uninitialized pointer Ahmad Fatoum
2019-08-22  5:51 ` [PATCH 11/11] fs: fat: fix use of wrong enumeration type Ahmad Fatoum
2019-08-22  6:38 ` [PATCH] ARM: don't use -no-thumb-interwork if unavailable Ahmad Fatoum
2019-08-23  7:20 ` [PATCH 00/11] treewide: fix some ARCH=arm clang warnings Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822055114.931-10-ahmad@a3f.at \
    --to=ahmad@a3f.at \
    --cc=afa@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox