mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 4/8] ARM: i.MX: imx8-ddrc: Remove debug code
Date: Thu, 22 Aug 2019 14:51:54 +0200	[thread overview]
Message-ID: <20190822125158.10296-5-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20190822125158.10296-1-s.hauer@pengutronix.de>

various puthex_ll() printed values without any context are not helpful when
debugging unrelated stuff, so remove them. When they are really needed
they should be added with proper pr_debug() statements.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/mach-imx/imx8-ddrc.c | 20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/arch/arm/mach-imx/imx8-ddrc.c b/arch/arm/mach-imx/imx8-ddrc.c
index 736865eb6f..8bb2672102 100644
--- a/arch/arm/mach-imx/imx8-ddrc.c
+++ b/arch/arm/mach-imx/imx8-ddrc.c
@@ -69,15 +69,8 @@ static void ddrc_phy_fetch_streaming_message(void __iomem *phy)
 	const u16 index = ddrc_phy_get_message(phy, PMC_MESSAGE_STREAM);
 	u16 i;
 
-	putc_ll('|');
-	puthex_ll(index);
-
-	for (i = 0; i < index; i++) {
-		const u32 arg = ddrc_phy_get_message(phy, PMC_MESSAGE_STREAM);
-
-		putc_ll('|');
-		puthex_ll(arg);
-	}
+	for (i = 0; i < index; i++)
+		ddrc_phy_get_message(phy, PMC_MESSAGE_STREAM);
 }
 
 void ddrc_phy_wait_training_complete(void __iomem *phy)
@@ -85,23 +78,14 @@ void ddrc_phy_wait_training_complete(void __iomem *phy)
 	for (;;) {
 		const u32 m = ddrc_phy_get_message(phy, PMC_MESSAGE_ID);
 
-		puthex_ll(m);
-
 		switch (m) {
 		case PMC_TRAIN_STREAM_START:
 			ddrc_phy_fetch_streaming_message(phy);
 			break;
 		case PMC_TRAIN_SUCCESS:
-			putc_ll('P');
-			putc_ll('\r');
-			putc_ll('\n');
 			return;
 		case PMC_TRAIN_FAIL:
-			putc_ll('F');
 			hang();
 		}
-
-		putc_ll('\r');
-		putc_ll('\n');
 	}
 }
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2019-08-22 12:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 12:51 [PATCH 0/8] i.MX8 EVK patches Sascha Hauer
2019-08-22 12:51 ` [PATCH 1/8] ARM: aarch64: Fixup relocation table for the second relocation Sascha Hauer
2019-08-22 13:09   ` Rouven Czerwinski
2019-08-22 12:51 ` [PATCH 2/8] ARM: aarch64: Fix get_runtime_offset after relocation Sascha Hauer
2019-08-22 13:08   ` Rouven Czerwinski
2019-08-22 20:14   ` Andrey Smirnov
2019-08-23  8:11     ` Sascha Hauer
2019-08-22 12:51 ` [PATCH 3/8] pbl: Move piggy verification into pbl_barebox_uncompress() Sascha Hauer
2019-08-22 13:07   ` Rouven Czerwinski
2019-08-22 12:51 ` Sascha Hauer [this message]
2019-08-22 13:04   ` [PATCH 4/8] ARM: i.MX: imx8-ddrc: Remove debug code Rouven Czerwinski
2019-08-22 12:51 ` [PATCH 5/8] ARM: nxp-imx8mq-evk: Remove duplicate call to imx8mq_cpu_lowlevel_init() Sascha Hauer
2019-08-22 13:03   ` Rouven Czerwinski
2019-08-22 12:51 ` [PATCH 6/8] ARM: nxp-imx8mq-evk: Replace trampoline Sascha Hauer
2019-08-22 13:03   ` Rouven Czerwinski
2019-08-22 12:51 ` [PATCH 7/8] ARM: i.MX8: Fix piggydata loading Sascha Hauer
2019-08-22 13:02   ` Rouven Czerwinski
2019-08-22 12:51 ` [PATCH 8/8] ARM: nxp-imx8mq-evk: Update comments Sascha Hauer
2019-08-22 12:59   ` Rouven Czerwinski
2019-08-22 13:19 ` [PATCH 0/8] i.MX8 EVK patches Rouven Czerwinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822125158.10296-5-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox