From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH RFC 0/3] fs: tftp: don't use cached dentries
Date: Fri, 23 Aug 2019 09:38:39 +0200 [thread overview]
Message-ID: <20190823073839.y2ghi7ptfg63lzev@pengutronix.de> (raw)
In-Reply-To: <20190822065102.22024-1-ahmad@a3f.at>
On Thu, Aug 22, 2019 at 08:50:59AM +0200, Ahmad Fatoum wrote:
> I often mistype the name of files I place into the TFTP server's root
> directory. When barebox does a TFTP lookup for the correct file name and
> doesn't find it, it refuses to look it up again. I'd argue the better
> user experience for TFTP in particular would be to not use the dcache
> altogether. Not sure if other networked file systems should follow suit,
> as staleness means faster acceses, but lets do this for TFTP now.
>
> The file is still placed and invalidated from the cache though, but
> compared to the network access before, it's negligible overhead.
>
> Ahmad Fatoum (3):
> fs: tftp: remove duplicate header
> fs: provide no_revalidate_d_ops for network file systems
> fs: tftp: don't maintain tftp dentries in dcache
Applied, thanks. I stumbled upon this behaviour myself aswell.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-08-23 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 6:50 Ahmad Fatoum
2019-08-22 6:51 ` [PATCH RFC 1/3] fs: tftp: remove duplicate header Ahmad Fatoum
2019-08-22 6:51 ` [PATCH RFC 2/3] fs: provide no_revalidate_d_ops for network file systems Ahmad Fatoum
2019-08-22 6:51 ` [PATCH RFC 3/3] fs: tftp: don't maintain tftp dentries in dcache Ahmad Fatoum
2019-08-23 7:38 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823073839.y2ghi7ptfg63lzev@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox