mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>, g@pengutronix.de
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/6] sandbox: hostfile: allow probing from device tree
Date: Wed, 28 Aug 2019 13:49:15 +0200	[thread overview]
Message-ID: <20190828114915.zkz6tbf3k5i235eb@pengutronix.de> (raw)
In-Reply-To: <20190827143239.15682-6-ahmad@a3f.at>

On Tue, Aug 27, 2019 at 04:32:38PM +0200, Ahmad Fatoum wrote:
> When testing things like barebox state in sandbox, it's nice to be able
> to refer to a partition on a hostfile by phandle. Support this by
> checking for reading the barebox,filename property.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  arch/sandbox/board/hostfile.c                 | 16 ++++--
>  arch/sandbox/dts/sandbox-state.dtsi           | 50 +++++++++++++++++++
>  .../sandbox/mach-sandbox/include/mach/linux.h |  1 +
>  arch/sandbox/os/common.c                      |  5 ++
>  4 files changed, 68 insertions(+), 4 deletions(-)
>  create mode 100644 arch/sandbox/dts/sandbox-state.dtsi
> 
> diff --git a/arch/sandbox/board/hostfile.c b/arch/sandbox/board/hostfile.c
> index 745f078d1a79..e5a7580d0792 100644
> --- a/arch/sandbox/board/hostfile.c
> +++ b/arch/sandbox/board/hostfile.c
> @@ -84,15 +84,16 @@ static int hf_probe(struct device_d *dev)
>  	if (!dev->device_node)
>  		return -ENODEV;
>  
> -	err = of_property_read_u32(dev->device_node, "barebox,fd", &priv->fd);
> -	if (err)
> -		return err;
> +	of_property_read_u32(dev->device_node, "barebox,fd", &priv->fd);
>  
>  	err = of_property_read_string(dev->device_node, "barebox,filename",
>  				      &priv->filename);
>  	if (err)
>  		return err;
>  
> +	if (!priv->fd)
> +		priv->fd = linux_open(priv->filename, true);
> +
>  	priv->cdev.name = dev->device_node->name;
>  	priv->cdev.dev = dev;
>  	priv->cdev.ops = &hf_fops;
> @@ -101,7 +102,14 @@ static int hf_probe(struct device_d *dev)
>  	dev->info = hf_info;
>  	dev->priv = priv;
>  
> -	return devfs_create(&priv->cdev);
> +	err = devfs_create(&priv->cdev);
> +	if (err)
> +		return err;
> +
> +	of_parse_partitions(&priv->cdev, dev->device_node);
> +	of_partitions_register_fixup(&priv->cdev);
> +
> +	return 0;
>  }
>  
>  static __maybe_unused struct of_device_id hostfile_dt_ids[] = {
> diff --git a/arch/sandbox/dts/sandbox-state.dtsi b/arch/sandbox/dts/sandbox-state.dtsi
> new file mode 100644
> index 000000000000..fc17bd078899
> --- /dev/null
> +++ b/arch/sandbox/dts/sandbox-state.dtsi
> @@ -0,0 +1,50 @@

This file doesn't belong into this patch.

Applied 1-4 for now.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-08-28 11:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 14:32 [PATCH 0/6] sandbox: add HWRNG driver for host /dev/random Ahmad Fatoum
2019-08-27 14:32 ` [PATCH 1/6] sandbox: include header to provide missing prototype Ahmad Fatoum
2019-08-27 14:32 ` [PATCH 2/6] sandbox: remove unused ARCH_LINUX Kconfig symbol Ahmad Fatoum
2019-08-27 14:32 ` [PATCH 3/6] sandbox: redefine optarg and optind to avoid collisions Ahmad Fatoum
2019-08-27 14:32 ` [PATCH 4/6] sandbox: compile with symbol -fvisibility=hidden Ahmad Fatoum
2019-08-27 14:32 ` [PATCH 5/6] sandbox: hostfile: allow probing from device tree Ahmad Fatoum
2019-08-28 11:49   ` Sascha Hauer [this message]
2019-08-28 12:06     ` Ahmad Fatoum
2019-08-27 14:32 ` [PATCH 6/6] hwrng: add sandbox driver interface to host /dev/random Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828114915.zkz6tbf3k5i235eb@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=ahmad@a3f.at \
    --cc=barebox@lists.infradead.org \
    --cc=g@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox