Re: [PATCH] gpio: iopoll: implement gpio_poll_timeout_us

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Aug 29, 2019 at 02:43:18PM +0200, Ahmad Fatoum wrote:
> Sometimes we need to wait for state change on a GPIO,
> provide a helper to do this.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  include/gpio.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/include/gpio.h b/include/gpio.h
> index 1926edeca757..89cb306a195c 100644
> --- a/include/gpio.h
> +++ b/include/gpio.h
> @@ -3,6 +3,7 @@
>  
>  #include <linux/types.h>
>  #include <linux/list.h>
> +#include <linux/iopoll.h>
>  
>  #ifdef CONFIG_GENERIC_GPIO
>  void gpio_set_value(unsigned gpio, int value);
> @@ -31,6 +32,13 @@ static inline int gpio_direction_input(unsigned gpio)
>  void gpio_set_active(unsigned gpio, bool state);
>  int gpio_is_active(unsigned gpio);
>  int gpio_direction_active(unsigned gpio, bool state);
> +
> +#define gpio_poll_timeout_us(gpio, active, timeout_us)			\

Please add a comment what this macro does. Specificall it's interesting
to know if this function polls as long as the gpio is active or if it
polls until it's active.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox