mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>, sha@pengutronix.de
Subject: [PATCH] fixup! i2c: port Linux i2c_parse_fw_timings
Date: Mon,  9 Sep 2019 15:26:49 +0200	[thread overview]
Message-ID: <20190909132648.15294-1-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20190909091542.15671-2-a.fatoum@pengutronix.de>

I forgot to add <linux/property.h> in the patch series. After discussion
with Sascha, we could do away with it and just use the of_* helper
directly. Do this and fix the build error caused...
---
 drivers/i2c/i2c.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/drivers/i2c/i2c.c b/drivers/i2c/i2c.c
index 35ea63ab0729..9df5ee70c7f1 100644
--- a/drivers/i2c/i2c.c
+++ b/drivers/i2c/i2c.c
@@ -24,7 +24,6 @@
 #include <init.h>
 #include <of.h>
 #include <gpio.h>
-#include <linux/property.h>
 
 #include <i2c/i2c.h>
 
@@ -579,11 +578,13 @@ void i2c_parse_fw_timings(struct device_d *dev, struct i2c_timings *t, bool use_
 
 	memset(t, 0, sizeof(*t));
 
-	ret = device_property_read_u32(dev, "clock-frequency", &t->bus_freq_hz);
+	ret = of_property_read_u32(dev->device_node, "clock-frequency",
+				   &t->bus_freq_hz);
 	if (ret && use_defaults)
 		t->bus_freq_hz = 100000;
 
-	ret = device_property_read_u32(dev, "i2c-scl-rising-time-ns", &t->scl_rise_ns);
+	ret = of_property_read_u32(dev->device_node, "i2c-scl-rising-time-ns",
+				   &t->scl_rise_ns);
 	if (ret && use_defaults) {
 		if (t->bus_freq_hz <= 100000)
 			t->scl_rise_ns = 1000;
@@ -593,7 +594,8 @@ void i2c_parse_fw_timings(struct device_d *dev, struct i2c_timings *t, bool use_
 			t->scl_rise_ns = 120;
 	}
 
-	ret = device_property_read_u32(dev, "i2c-scl-falling-time-ns", &t->scl_fall_ns);
+	ret = of_property_read_u32(dev->device_node, "i2c-scl-falling-time-ns",
+				   &t->scl_fall_ns);
 	if (ret && use_defaults) {
 		if (t->bus_freq_hz <= 400000)
 			t->scl_fall_ns = 300;
@@ -601,13 +603,16 @@ void i2c_parse_fw_timings(struct device_d *dev, struct i2c_timings *t, bool use_
 			t->scl_fall_ns = 120;
 	}
 
-	device_property_read_u32(dev, "i2c-scl-internal-delay-ns", &t->scl_int_delay_ns);
+	of_property_read_u32(dev->device_node, "i2c-scl-internal-delay-ns",
+			     &t->scl_int_delay_ns);
 
-	ret = device_property_read_u32(dev, "i2c-sda-falling-time-ns", &t->sda_fall_ns);
+	ret = of_property_read_u32(dev->device_node, "i2c-sda-falling-time-ns",
+				   &t->sda_fall_ns);
 	if (ret && use_defaults)
 		t->sda_fall_ns = t->scl_fall_ns;
 
-	device_property_read_u32(dev, "i2c-sda-hold-time-ns", &t->sda_hold_ns);
+	of_property_read_u32(dev->device_node, "i2c-sda-hold-time-ns",
+			     &t->sda_hold_ns);
 }
 EXPORT_SYMBOL_GPL(i2c_parse_fw_timings);
 
-- 
2.23.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-09-09 13:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09  9:15 [PATCH v2 0/4] stm32mp: add support for STPMIC1 Ahmad Fatoum
2019-09-09  9:15 ` [PATCH v2 1/4] i2c: port Linux i2c_parse_fw_timings Ahmad Fatoum
2019-09-09 13:26   ` Ahmad Fatoum [this message]
2019-09-09  9:15 ` [PATCH v2 2/4] i2c: add stm32f7 I2C adapter driver Ahmad Fatoum
2019-09-09  9:15 ` [PATCH v2 3/4] mfd: add support for STPMIC1 Ahmad Fatoum
2019-09-09  9:15 ` [PATCH v2 4/4] watchdog: add support for STPMIC1 integrated watchdog Ahmad Fatoum
2019-09-09 13:44 ` [PATCH v2 0/4] stm32mp: add support for STPMIC1 Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190909132648.15294-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox