From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v4 2/2] mci: implement command to switch a mmc device to enhanced mode
Date: Thu, 12 Sep 2019 08:47:25 +0200 [thread overview]
Message-ID: <20190912064725.72dg6dykqnu7vzvh@pengutronix.de> (raw)
In-Reply-To: <20190912064240.nyljjoqhgdharwk7@pengutronix.de>
On Thu, Sep 12, 2019 at 08:42:40AM +0200, Uwe Kleine-König wrote:
> Hello,
>
> -m was an intermediate step. You suggested to use -m instead of
> "setmax", but while implementing I noticed that with options there is no
> need for a keyword or option.
>
> Can you please squash this into my patch?:
>
> diff --git a/commands/mmc.c b/commands/mmc.c
> index b51522fce2a6..c696e7b8817b 100644
> --- a/commands/mmc.c
> +++ b/commands/mmc.c
> @@ -80,7 +80,7 @@ static u8 *mci_get_ext_csd(struct mci *mci)
> return ext_csd;
> }
>
> -/* enh_area -m [-c] /dev/mmcX */
> +/* enh_area [-c] /dev/mmcX */
> static int do_mmc_enh_area(int argc, char *argv[])
> {
> const char *devpath;
> @@ -98,10 +98,6 @@ static int do_mmc_enh_area(int argc, char *argv[])
> }
> }
>
> - /*
> - * -m is currently mandatory to allow more flexible enhanced area
> - * specifications in the future.
> - */
> if (argc - optind != 1) {
> printf("Usage: mmc enh_area [-c] /dev/mmcX\n");
> return COMMAND_ERROR_USAGE;
>
> or should I resend?
squashed into the patch, no need to resend. Thanks,
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-09-12 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 20:34 [PATCH v4 0/2] simplify setting enhanced area of mmc devices Uwe Kleine-König
2019-09-09 20:34 ` [PATCH v4 1/2] mci: provide wrapper for mci_get_device_by_name ∘ devpath_to_name Uwe Kleine-König
2019-09-09 20:34 ` [PATCH v4 2/2] mci: implement command to switch a mmc device to enhanced mode Uwe Kleine-König
2019-09-12 6:16 ` Sascha Hauer
2019-09-12 6:42 ` Uwe Kleine-König
2019-09-12 6:47 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912064725.72dg6dykqnu7vzvh@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox