From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org>
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
 by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux))
 id 1i8miJ-0003q1-AD
 for barebox@lists.infradead.org; Fri, 13 Sep 2019 14:38:21 +0000
Date: Fri, 13 Sep 2019 16:38:15 +0200
From: Roland Hieber <rhi@pengutronix.de>
Message-ID: <20190913143815.3pgaitt2pj2s54kv@pengutronix.de>
References: <20190912102905.21307-1-a.fatoum@pengutronix.de>
 <20190912102905.21307-5-a.fatoum@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20190912102905.21307-5-a.fatoum@pengutronix.de>
List-Id: <barebox.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/barebox>,
 <mailto:barebox-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/barebox/>
List-Post: <mailto:barebox@lists.infradead.org>
List-Help: <mailto:barebox-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/barebox>,
 <mailto:barebox-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "barebox" <barebox-bounces@lists.infradead.org>
Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org
Subject: Re: [PATCH 5/7] scripts: pblimage: explicitly set architecture to ARM
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org

On Thu, Sep 12, 2019 at 12:29:03PM +0200, Ahmad Fatoum wrote:
> architecture is statically initialized to zero, which happens to be
> ARCH_ARM as it's the first enum element.
> Make this a bit clearer by explicitly assigning ARM_ARM to architecture.

Nit: s/ARM_ARM/ARCH_ARM/

> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  scripts/pblimage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/pblimage.c b/scripts/pblimage.c
> index 73c0169ac1c1..235af8aa11b1 100644
> --- a/scripts/pblimage.c
> +++ b/scripts/pblimage.c
> @@ -61,7 +61,7 @@ enum arch {
>  	ARCH_POWERPC,
>  };
>  
> -enum arch architecture;
> +enum arch architecture = ARCH_ARM;
>  static char *rcwfile;
>  static char *pbifile;
>  static char *outfile;
> -- 
> 2.23.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox