mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: aarch64: add image markers to linker script
@ 2019-10-01 12:45 Rouven Czerwinski
  2019-10-02  7:14 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Rouven Czerwinski @ 2019-10-01 12:45 UTC (permalink / raw)
  To: barebox; +Cc: Rouven Czerwinski

The __image_start and __image_end marker are used by barebox to
calculate the size of the barebox binary inside the RAM. Without the
definitions barebox calculates its own size to zero, which works until a
certain size is exceeded, than the PBL will place the binary lower into
memory than the calculation inside barebox.
Fix this by adding the appropriate image markers to the linker script.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
 arch/arm/lib64/barebox.lds.S | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/lib64/barebox.lds.S b/arch/arm/lib64/barebox.lds.S
index b3e6843a15..694bbcaaf1 100644
--- a/arch/arm/lib64/barebox.lds.S
+++ b/arch/arm/lib64/barebox.lds.S
@@ -31,6 +31,8 @@ SECTIONS
 	. = TEXT_BASE;
 #endif
 
+	.image_start : { *(.__image_start) }
+
 #ifndef CONFIG_PBL_IMAGE
 	PRE_IMAGE
 #endif
@@ -112,6 +114,8 @@ SECTIONS
 
 	_edata = .;
 
+	.image_end : { *(.__image_end) }
+
 	. = ALIGN(4);
 	.__bss_start :  { *(.__bss_start) }
 	.bss : { *(.bss*) }
-- 
2.23.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: aarch64: add image markers to linker script
  2019-10-01 12:45 [PATCH] ARM: aarch64: add image markers to linker script Rouven Czerwinski
@ 2019-10-02  7:14 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-10-02  7:14 UTC (permalink / raw)
  To: Rouven Czerwinski; +Cc: barebox

On Tue, Oct 01, 2019 at 02:45:04PM +0200, Rouven Czerwinski wrote:
> The __image_start and __image_end marker are used by barebox to
> calculate the size of the barebox binary inside the RAM. Without the
> definitions barebox calculates its own size to zero, which works until a
> certain size is exceeded, than the PBL will place the binary lower into
> memory than the calculation inside barebox.
> Fix this by adding the appropriate image markers to the linker script.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  arch/arm/lib64/barebox.lds.S | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-02  7:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 12:45 [PATCH] ARM: aarch64: add image markers to linker script Rouven Czerwinski
2019-10-02  7:14 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox