From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org, s.christ@phytec.de,
s.riedmueller@phytec.de, j.remmet@phytec.de
Subject: Re: [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
Date: Wed, 2 Oct 2019 09:23:11 +0200 [thread overview]
Message-ID: <20191002072310.36lu4bxnao3eaulk@pengutronix.de> (raw)
In-Reply-To: <20191002072043.ujput2lroimm3yx6@pengutronix.de>
Marco,
On Wed, Oct 02, 2019 at 09:20:43AM +0200, Sascha Hauer wrote:
> +Cc Christian Hemp who is the author of b6bebb7aca
>
> On Wed, Sep 11, 2019 at 04:53:28PM +0200, Marco Felsch wrote:
> > The PMIC is connected to i2c3 and not i2c1.
> >
> > Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> > arch/arm/boards/phytec-som-imx6/board.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
> > index 730115702b..38e5ede91a 100644
> > --- a/arch/arm/boards/phytec-som-imx6/board.c
> > +++ b/arch/arm/boards/phytec-som-imx6/board.c
> > @@ -117,7 +117,7 @@ static int phycore_da9062_setup_buck_mode(void)
> > struct i2c_adapter *adapter = NULL;
> > struct i2c_client client;
> > unsigned char value;
> > - int bus = 0;
> > + int bus = 2;
> > int ret;
> >
> > adapter = i2c_get_adapter(bus);
You could test it directly on b6bebb7aca instead of master. Is this
change necessary there aswell or has the bus numbering changed in
between?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-10-02 7:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 14:53 Marco Felsch
2019-09-20 14:11 ` Marco Felsch
2019-10-02 7:20 ` Sascha Hauer
2019-10-02 7:23 ` Sascha Hauer [this message]
2019-10-02 7:34 ` Stefan Riedmüller
2019-10-02 8:34 ` Marco Felsch
2019-10-02 8:53 ` Stefan Riedmüller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002072310.36lu4bxnao3eaulk@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=j.remmet@phytec.de \
--cc=m.felsch@pengutronix.de \
--cc=s.christ@phytec.de \
--cc=s.riedmueller@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox