[PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators

mail archive of the barebox mailing list
 help / color / mirror / Atom feed

* [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
@ 2019-09-11 14:53 Marco Felsch
  2019-09-20 14:11 ` Marco Felsch
  2019-10-02  7:20 ` Sascha Hauer
  0 siblings, 2 replies; 7+ messages in thread
From: Marco Felsch @ 2019-09-11 14:53 UTC (permalink / raw)
  To: barebox; +Cc: s.christ, j.remmet, s.riedmueller

The PMIC is connected to i2c3 and not i2c1.

Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 arch/arm/boards/phytec-som-imx6/board.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
index 730115702b..38e5ede91a 100644
--- a/arch/arm/boards/phytec-som-imx6/board.c
+++ b/arch/arm/boards/phytec-som-imx6/board.c
@@ -117,7 +117,7 @@ static int phycore_da9062_setup_buck_mode(void)
 	struct i2c_adapter *adapter = NULL;
 	struct i2c_client client;
 	unsigned char value;
-	int bus = 0;
+	int bus = 2;
 	int ret;
 
 	adapter = i2c_get_adapter(bus);
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
  2019-09-11 14:53 [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators Marco Felsch
@ 2019-09-20 14:11 ` Marco Felsch
  2019-10-02  7:20 ` Sascha Hauer
  1 sibling, 0 replies; 7+ messages in thread
From: Marco Felsch @ 2019-09-20 14:11 UTC (permalink / raw)
  To: barebox; +Cc: s.christ, s.riedmueller, j.remmet

Hi,

@phytec

Please can you test this? This fixes the issue for my SoM-Rev. but I don't
wanna break other SoM Revisions.

Regards,
  Marco


On 19-09-11 16:53, Marco Felsch wrote:
> The PMIC is connected to i2c3 and not i2c1.
> 
> Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  arch/arm/boards/phytec-som-imx6/board.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
> index 730115702b..38e5ede91a 100644
> --- a/arch/arm/boards/phytec-som-imx6/board.c
> +++ b/arch/arm/boards/phytec-som-imx6/board.c
> @@ -117,7 +117,7 @@ static int phycore_da9062_setup_buck_mode(void)
>  	struct i2c_adapter *adapter = NULL;
>  	struct i2c_client client;
>  	unsigned char value;
> -	int bus = 0;
> +	int bus = 2;
>  	int ret;
>  
>  	adapter = i2c_get_adapter(bus);
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
  2019-09-11 14:53 [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators Marco Felsch
  2019-09-20 14:11 ` Marco Felsch
@ 2019-10-02  7:20 ` Sascha Hauer
  2019-10-02  7:23   ` Sascha Hauer
  1 sibling, 1 reply; 7+ messages in thread
From: Sascha Hauer @ 2019-10-02  7:20 UTC (permalink / raw)
  To: Marco Felsch; +Cc: barebox, s.christ, s.riedmueller, j.remmet

+Cc Christian Hemp who is the author of b6bebb7aca

On Wed, Sep 11, 2019 at 04:53:28PM +0200, Marco Felsch wrote:
> The PMIC is connected to i2c3 and not i2c1.
> 
> Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  arch/arm/boards/phytec-som-imx6/board.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
> index 730115702b..38e5ede91a 100644
> --- a/arch/arm/boards/phytec-som-imx6/board.c
> +++ b/arch/arm/boards/phytec-som-imx6/board.c
> @@ -117,7 +117,7 @@ static int phycore_da9062_setup_buck_mode(void)
>  	struct i2c_adapter *adapter = NULL;
>  	struct i2c_client client;
>  	unsigned char value;
> -	int bus = 0;
> +	int bus = 2;
>  	int ret;
>  
>  	adapter = i2c_get_adapter(bus);
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
  2019-10-02  7:20 ` Sascha Hauer
@ 2019-10-02  7:23   ` Sascha Hauer
  2019-10-02  7:34     ` Stefan Riedmüller
  0 siblings, 1 reply; 7+ messages in thread
From: Sascha Hauer @ 2019-10-02  7:23 UTC (permalink / raw)
  To: Marco Felsch; +Cc: barebox, s.christ, s.riedmueller, j.remmet

Marco,

On Wed, Oct 02, 2019 at 09:20:43AM +0200, Sascha Hauer wrote:
> +Cc Christian Hemp who is the author of b6bebb7aca
> 
> On Wed, Sep 11, 2019 at 04:53:28PM +0200, Marco Felsch wrote:
> > The PMIC is connected to i2c3 and not i2c1.
> > 
> > Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  arch/arm/boards/phytec-som-imx6/board.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
> > index 730115702b..38e5ede91a 100644
> > --- a/arch/arm/boards/phytec-som-imx6/board.c
> > +++ b/arch/arm/boards/phytec-som-imx6/board.c
> > @@ -117,7 +117,7 @@ static int phycore_da9062_setup_buck_mode(void)
> >  	struct i2c_adapter *adapter = NULL;
> >  	struct i2c_client client;
> >  	unsigned char value;
> > -	int bus = 0;
> > +	int bus = 2;
> >  	int ret;
> >  
> >  	adapter = i2c_get_adapter(bus);

You could test it directly on b6bebb7aca instead of master. Is this
change necessary there aswell or has the bus numbering changed in
between?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
  2019-10-02  7:23   ` Sascha Hauer
@ 2019-10-02  7:34     ` Stefan Riedmüller
  2019-10-02  8:34       ` Marco Felsch
  0 siblings, 1 reply; 7+ messages in thread
From: Stefan Riedmüller @ 2019-10-02  7:34 UTC (permalink / raw)
  To: Sascha Hauer, Marco Felsch; +Cc: barebox, s.christ, j.remmet

Hi Marco, Sascha,
On 02.10.19 09:23, Sascha Hauer wrote:
> Marco,
> 
> On Wed, Oct 02, 2019 at 09:20:43AM +0200, Sascha Hauer wrote:
>> +Cc Christian Hemp who is the author of b6bebb7aca
>>
>> On Wed, Sep 11, 2019 at 04:53:28PM +0200, Marco Felsch wrote:
>>> The PMIC is connected to i2c3 and not i2c1.
>>>
>>> Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
>>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>>> ---
>>>   arch/arm/boards/phytec-som-imx6/board.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
>>> index 730115702b..38e5ede91a 100644
>>> --- a/arch/arm/boards/phytec-som-imx6/board.c
>>> +++ b/arch/arm/boards/phytec-som-imx6/board.c
>>> @@ -117,7 +117,7 @@ static int phycore_da9062_setup_buck_mode(void)
>>>   	struct i2c_adapter *adapter = NULL;
>>>   	struct i2c_client client;
>>>   	unsigned char value;
>>> -	int bus = 0;
>>> +	int bus = 2;
>>>   	int ret;
>>>   
>>>   	adapter = i2c_get_adapter(bus);
> 
> You could test it directly on b6bebb7aca instead of master. Is this
> change necessary there aswell or has the bus numbering changed in
> between?

this bus numbering changed with Marco's patch to use the upstream device tree.

ARM: dts: imx6: phycore: make use of upstream dts

The phyCORE-i.MX 6 uses just one i2c interface but on the phyBOARD-Mira two 
more i2c interfaces are used.

Stefan

> 
> Sascha
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
  2019-10-02  7:34     ` Stefan Riedmüller
@ 2019-10-02  8:34       ` Marco Felsch
  2019-10-02  8:53         ` Stefan Riedmüller
  0 siblings, 1 reply; 7+ messages in thread
From: Marco Felsch @ 2019-10-02  8:34 UTC (permalink / raw)
  To: Stefan Riedmüller; +Cc: barebox, s.christ, j.remmet

Hi Stefan,

On 19-10-02 09:34, Stefan Riedmüller wrote:
> Hi Marco, Sascha,
> On 02.10.19 09:23, Sascha Hauer wrote:
> > Marco,
> > 
> > On Wed, Oct 02, 2019 at 09:20:43AM +0200, Sascha Hauer wrote:
> > > +Cc Christian Hemp who is the author of b6bebb7aca
> > > 
> > > On Wed, Sep 11, 2019 at 04:53:28PM +0200, Marco Felsch wrote:
> > > > The PMIC is connected to i2c3 and not i2c1.
> > > > 
> > > > Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
> > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > > ---
> > > >   arch/arm/boards/phytec-som-imx6/board.c | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
> > > > index 730115702b..38e5ede91a 100644
> > > > --- a/arch/arm/boards/phytec-som-imx6/board.c
> > > > +++ b/arch/arm/boards/phytec-som-imx6/board.c
> > > > @@ -117,7 +117,7 @@ static int phycore_da9062_setup_buck_mode(void)
> > > >   	struct i2c_adapter *adapter = NULL;
> > > >   	struct i2c_client client;
> > > >   	unsigned char value;
> > > > -	int bus = 0;
> > > > +	int bus = 2;
> > > >   	int ret;
> > > >   	adapter = i2c_get_adapter(bus);
> > 
> > You could test it directly on b6bebb7aca instead of master. Is this
> > change necessary there aswell or has the bus numbering changed in
> > between?
> 
> this bus numbering changed with Marco's patch to use the upstream device tree.
> 
> ARM: dts: imx6: phycore: make use of upstream dts
> 
> The phyCORE-i.MX 6 uses just one i2c interface but on the phyBOARD-Mira two
> more i2c interfaces are used.

Or if another baseboard uses the SoM and a Baseboard with more i2c interfaces.
After talking with Sascha we should fix this by using
of_find_i2c_adapter_by_node(). So it is fixed in my case and in your
case too. Are you agree?

Regards,
  Marco

> 
> Stefan
> 
> > 
> > Sascha
> > 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
  2019-10-02  8:34       ` Marco Felsch
@ 2019-10-02  8:53         ` Stefan Riedmüller
  0 siblings, 0 replies; 7+ messages in thread
From: Stefan Riedmüller @ 2019-10-02  8:53 UTC (permalink / raw)
  To: Marco Felsch; +Cc: barebox, s.christ, j.remmet

Hi Marco,

On 02.10.19 10:34, Marco Felsch wrote:
> Hi Stefan,
> 
> On 19-10-02 09:34, Stefan Riedmüller wrote:
>> Hi Marco, Sascha,
>> On 02.10.19 09:23, Sascha Hauer wrote:
>>> Marco,
>>>
>>> On Wed, Oct 02, 2019 at 09:20:43AM +0200, Sascha Hauer wrote:
>>>> +Cc Christian Hemp who is the author of b6bebb7aca
>>>>
>>>> On Wed, Sep 11, 2019 at 04:53:28PM +0200, Marco Felsch wrote:
>>>>> The PMIC is connected to i2c3 and not i2c1.
>>>>>
>>>>> Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
>>>>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>>>>> ---
>>>>>    arch/arm/boards/phytec-som-imx6/board.c | 2 +-
>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
>>>>> index 730115702b..38e5ede91a 100644
>>>>> --- a/arch/arm/boards/phytec-som-imx6/board.c
>>>>> +++ b/arch/arm/boards/phytec-som-imx6/board.c
>>>>> @@ -117,7 +117,7 @@ static int phycore_da9062_setup_buck_mode(void)
>>>>>    	struct i2c_adapter *adapter = NULL;
>>>>>    	struct i2c_client client;
>>>>>    	unsigned char value;
>>>>> -	int bus = 0;
>>>>> +	int bus = 2;
>>>>>    	int ret;
>>>>>    	adapter = i2c_get_adapter(bus);
>>>
>>> You could test it directly on b6bebb7aca instead of master. Is this
>>> change necessary there aswell or has the bus numbering changed in
>>> between?
>>
>> this bus numbering changed with Marco's patch to use the upstream device tree.
>>
>> ARM: dts: imx6: phycore: make use of upstream dts
>>
>> The phyCORE-i.MX 6 uses just one i2c interface but on the phyBOARD-Mira two
>> more i2c interfaces are used.
> 
> Or if another baseboard uses the SoM and a Baseboard with more i2c interfaces.
> After talking with Sascha we should fix this by using
> of_find_i2c_adapter_by_node(). So it is fixed in my case and in your
> case too. Are you agree?

Yes I like that!

Regards,
Stefan

> 
> Regards,
>    Marco
> 
>>
>> Stefan
>>
>>>
>>> Sascha
>>>
>>
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-10-02  8:53 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 14:53 [PATCH] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators Marco Felsch
2019-09-20 14:11 ` Marco Felsch
2019-10-02  7:20 ` Sascha Hauer
2019-10-02  7:23   ` Sascha Hauer
2019-10-02  7:34     ` Stefan Riedmüller
2019-10-02  8:34       ` Marco Felsch
2019-10-02  8:53         ` Stefan Riedmüller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox