From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] version_string: Add toolchain and build host info
Date: Mon, 14 Oct 2019 14:00:14 +0200 [thread overview]
Message-ID: <20191014120014.l2weokpk6l2oscrg@pengutronix.de> (raw)
In-Reply-To: <20191001005718.27165-1-andrew.smirnov@gmail.com>
On Mon, Sep 30, 2019 at 05:57:18PM -0700, Andrey Smirnov wrote:
> Linux kernel reports the version of toolchain it was built with as a
> part of its version string, which can be extremely useful when
> debugging toolchain related issues. Make Barebox version string, mimic
> that of Linux to get the same level of information in Barebox.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> common/version.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/common/version.c b/common/version.c
> index 8b1fd4dbe7..5f57022dac 100644
> --- a/common/version.c
> +++ b/common/version.c
> @@ -3,7 +3,8 @@
> #include <generated/utsrelease.h>
>
> const char version_string[] =
> - "barebox " UTS_RELEASE " " UTS_VERSION "\n";
> + "barebox " UTS_RELEASE " (" BAREBOX_COMPILE_BY "@"
> + BAREBOX_COMPILE_HOST ") (" BAREBOX_COMPILER ") " UTS_VERSION "\n";
I think we shouldn't make version_string longer than it actually is. We
could print the information as additional lines (without adding it to
version_string), or as Antony suggested, as global variables.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-10-14 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 0:57 Andrey Smirnov
2019-10-01 6:03 ` Antony Pavlov
2019-10-08 5:14 ` Andrey Smirnov
2019-10-08 8:14 ` Antony Pavlov
2019-10-14 12:00 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014120014.l2weokpk6l2oscrg@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox