mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v2] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
@ 2019-10-02 13:09 Marco Felsch
  2019-10-04  7:58 ` Stefan Riedmüller
  2019-10-14 12:04 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Marco Felsch @ 2019-10-02 13:09 UTC (permalink / raw)
  To: barebox, s.christ, j.remmet, s.riedmueller, c.hemp; +Cc: mfe

Currently the fixup code assumes that only one i2c bus is active. If we
reuse the board code for other boards this isn't always true. Fix that
by using of_find_i2c_adapter_by_node() to address both cases.

Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
Changelog:

v2:
- Make use of of_find_i2c_adapter_by_node() to get the right adapter.
---
 arch/arm/boards/phytec-som-imx6/board.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
index 730115702b..27a1ad4f66 100644
--- a/arch/arm/boards/phytec-som-imx6/board.c
+++ b/arch/arm/boards/phytec-som-imx6/board.c
@@ -115,12 +115,16 @@ static int ksz8081_phy_fixup(struct phy_device *phydev)
 static int phycore_da9062_setup_buck_mode(void)
 {
 	struct i2c_adapter *adapter = NULL;
+	struct device_node *pmic_np = NULL;
 	struct i2c_client client;
 	unsigned char value;
-	int bus = 0;
 	int ret;
 
-	adapter = i2c_get_adapter(bus);
+	pmic_np = of_find_node_by_name(NULL, "pmic@58");
+	if (!pmic_np)
+		return -ENODEV;
+
+	adapter = of_find_i2c_adapter_by_node(pmic_np->parent);
 	if (!adapter)
 		return -ENODEV;
 
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
  2019-10-02 13:09 [PATCH v2] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators Marco Felsch
@ 2019-10-04  7:58 ` Stefan Riedmüller
  2019-10-14 12:04 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Riedmüller @ 2019-10-04  7:58 UTC (permalink / raw)
  To: Marco Felsch; +Cc: barebox, mfe, s.christ, j.remmet

Hi Marco,

On 02.10.19 15:09, Marco Felsch wrote:
> Currently the fixup code assumes that only one i2c bus is active. If we
> reuse the board code for other boards this isn't always true. Fix that
> by using of_find_i2c_adapter_by_node() to address both cases.
> 
> Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
> Signed-off-by: Marco Felsch<m.felsch@pengutronix.de>

Tested-by: Stefan Riedmueller <s.riedmueller@phytec.de>

Regards,
Stefan

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators
  2019-10-02 13:09 [PATCH v2] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators Marco Felsch
  2019-10-04  7:58 ` Stefan Riedmüller
@ 2019-10-14 12:04 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2019-10-14 12:04 UTC (permalink / raw)
  To: Marco Felsch; +Cc: barebox, s.riedmueller, mfe, s.christ, j.remmet

On Wed, Oct 02, 2019 at 03:09:59PM +0200, Marco Felsch wrote:
> Currently the fixup code assumes that only one i2c bus is active. If we
> reuse the board code for other boards this isn't always true. Fix that
> by using of_find_i2c_adapter_by_node() to address both cases.
> 
> Fixes: b6bebb7aca ("ARM: i.MX: phytec-som-imx6: phycore: Set BUCK mode to SYNC")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> Changelog:
> 
> v2:
> - Make use of of_find_i2c_adapter_by_node() to get the right adapter.
> ---
>  arch/arm/boards/phytec-som-imx6/board.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-14 12:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 13:09 [PATCH v2] ARM: i.MX: phytec-som-imx6: phycore: fix updating pmic regulators Marco Felsch
2019-10-04  7:58 ` Stefan Riedmüller
2019-10-14 12:04 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox