From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Middelschulte, Leif" <Leif.Middelschulte@klsmartin.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: erroneous behavior for iMX+GPT
Date: Mon, 14 Oct 2019 14:25:46 +0200 [thread overview]
Message-ID: <20191014122546.ey5bjayf7ilkohpj@pengutronix.de> (raw)
In-Reply-To: <ec68b5aec8f0a144e9391dd1dfabe129ecdd4b6a.camel@klsmartin.com>
Hi Leif,
On Mon, Oct 07, 2019 at 02:15:39PM +0000, Middelschulte, Leif wrote:
> Hi,
>
> setting up GPT on an iMX6, I noticed a small bug subject to
> CONFIG_PARTITION_DISK_EFI_GPT_NO_FORCE that leads to unparsed GPTs.
>
> Background: The iMX supports the mmc user partition as bootmedia
> source too.
>
> Problem: The (additional) filetype check[0] fails, if the given buffer
> contains multiple, subsequent file(type)s. The buffer might contain
> the beginning of a disk that contains i.e. a Barebox image *and* a
> partition table. The function file_detect_type returns a single (first
> recognized) type[1]. In my case, it returns the Barebox image type.
Looks like the file_detect_type() there should be replaced with
file_detect_partition_table().
>
> There is a comment about this additional check noting it will be
> mandatory as it will be "[..] added to the EFI Spec. per Intel after
> v1.02.". Anybody can elaborate on that?
> That feedback could help to understand why file_detect_partition_table
> is insufficient in this case.
What makes you think that file_detect_partition_table() is insufficient?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-10-14 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 14:15 Middelschulte, Leif
2019-10-14 12:25 ` Sascha Hauer [this message]
2019-10-14 12:30 ` Middelschulte, Leif
2019-10-14 12:45 ` s.hauer
2019-10-14 13:02 ` Middelschulte, Leif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014122546.ey5bjayf7ilkohpj@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Leif.Middelschulte@klsmartin.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox