From: Antony Pavlov <antonynpavlov@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] MIPS: init cache before flashing it
Date: Tue, 15 Oct 2019 23:41:06 +0300 [thread overview]
Message-ID: <20191015234106.9cfb8923875a4354d94b31ea@gmail.com> (raw)
In-Reply-To: <20191015160945.7930-1-o.rempel@pengutronix.de>
On Tue, 15 Oct 2019 18:09:45 +0200
Oleksij Rempel <o.rempel@pengutronix.de> wrote:
Hi!
Please review this thread http://lists.infradead.org/pipermail/barebox/2019-June/038530.html
AFAIR we have to clear BSS before calling r4k_cache_init().
--
Best regards,
Antony Pavlov
> Cache information was not initialized on flush_cache_all(). This was the
> reason for relatively slow boot speed on MIPS.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/mips/lib/reloc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/lib/reloc.c b/arch/mips/lib/reloc.c
> index 9a9e404f7e..3d05ff1381 100644
> --- a/arch/mips/lib/reloc.c
> +++ b/arch/mips/lib/reloc.c
> @@ -40,6 +40,7 @@
> #include <linux/sizes.h>
> #include <asm-generic/memory_layout.h>
>
> +void r4k_cache_init(void);
> void main_entry(void *fdt, u32 fdt_size);
> void relocate_code(void *fdt, u32 fdt_size, u32 relocaddr);
>
> @@ -146,6 +147,7 @@ void relocate_code(void *fdt, u32 fdt_size, u32 ram_size)
> apply_reloc(type, (void *)addr, off);
> }
>
> + r4k_cache_init();
> /* Ensure the icache is coherent */
> flush_cache_all();
>
> --
> 2.23.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-10-15 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 16:09 Oleksij Rempel
2019-10-15 20:41 ` Antony Pavlov [this message]
2019-10-16 4:28 ` Oleksij Rempel
2019-10-16 4:34 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015234106.9cfb8923875a4354d94b31ea@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox