From: Sascha Hauer <s.hauer@pengutronix.de>
To: Robert Karszniewicz <r.karszniewicz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3] libfile: copy_file: prevent spurious error message
Date: Mon, 21 Oct 2019 09:37:06 +0200 [thread overview]
Message-ID: <20191021073706.m3k2f4vop3ryu64c@pengutronix.de> (raw)
In-Reply-To: <7c7d28bb-0d1c-0b4f-7372-b409210b4a9f@phytec.de>
On Fri, Oct 18, 2019 at 07:15:27PM +0200, Robert Karszniewicz wrote:
> In all this haste, I forgot my question.
>
> What error codes should be used? For each goto its own code, in sequence,
> starting from -1?
Please propagate the error code returned from the call that failed. i.e.
something like:
r = read(srcfd, rw_buf, RW_BUF_SIZE);
if (r < 0) {
perror("read");
ret = r;
goto out;
}
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-10-21 7:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 15:59 [PATCH] " Robert Karszniewicz
2019-10-16 11:26 ` [PATCH v2] " Robert Karszniewicz
2019-10-18 11:45 ` Sascha Hauer
2019-10-18 17:10 ` [PATCH v3] " Robert Karszniewicz
2019-10-18 17:15 ` Robert Karszniewicz
2019-10-21 7:37 ` Sascha Hauer [this message]
2019-10-22 13:47 ` [PATCH v4] libfile: copy_file: fix error handling Robert Karszniewicz
2019-10-23 7:16 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021073706.m3k2f4vop3ryu64c@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.karszniewicz@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox