From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Barbier, Renaud" <renaud.barbier@abaco.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: barebox 2019.07 ubiformat
Date: Mon, 21 Oct 2019 09:52:18 +0200 [thread overview]
Message-ID: <20191021075218.7ij6jib4hcjsfx76@pengutronix.de> (raw)
In-Reply-To: <MN2PR16MB311709C5A0F09CA7B9F69A24916C0@MN2PR16MB3117.namprd16.prod.outlook.com>
Hi Renaud,
On Fri, Oct 18, 2019 at 03:09:00PM +0000, Barbier, Renaud wrote:
> Looking at the Linux nand_ecc, there is something specific for512 bytes size ecc:
>
> if (eccsize_mult == 2 && (i & 0x4) == 0)
> rp16 ^= tmppar;
>
> code[2] =
> + (invparity[par & 0xf0] << 7) |
> + (invparity[par & 0x0f] << 6) |
> + (invparity[par & 0xcc] << 5) |
> + (invparity[par & 0x33] << 4) |
> + (invparity[par & 0xaa] << 3) |
> + (invparity[par & 0x55] << 2) |
> + (invparity[rp17] << 1) |
> + (invparity[rp16] << 0);
>
> In barebox we have:
> ecc_code[2] = ((~reg1) << 2) | 0x03;
>
> So I guess there is a small change to do to support 512 bytes.
What we have in barebox currently seems to be the nand_ecc.c version of
Linux-2.6.25. A git log of that file from v2.6.25 to master has:
260dc003e9fd mtd: nand: fix 512 byte software ecc support
So yes, we do not seem to have 512 byte software ecc support.
I'd say just update nand_ecc.c to a recent Kernel version.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-10-21 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 17:44 Barbier, Renaud
2019-09-26 6:41 ` Sascha Hauer
2019-09-26 14:15 ` Barbier, Renaud
2019-09-27 6:44 ` Sascha Hauer
2019-09-27 8:43 ` Barbier, Renaud
2019-10-18 14:36 ` Barbier, Renaud
2019-10-18 15:09 ` Barbier, Renaud
2019-10-21 7:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021075218.7ij6jib4hcjsfx76@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=renaud.barbier@abaco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox