From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNAdS-0005Qd-Vs for barebox@lists.infradead.org; Wed, 23 Oct 2019 07:00:48 +0000 Date: Wed, 23 Oct 2019 09:00:41 +0200 From: Sascha Hauer Message-ID: <20191023070041.2dvdtmnql4z2cd4b@pengutronix.de> References: <20191021092341.27633-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191021092341.27633-1-a.fatoum@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] serial: efi-stdio: replace globals with handles in priv struct To: Ahmad Fatoum Cc: barebox@lists.infradead.org On Mon, Oct 21, 2019 at 11:23:40AM +0200, Ahmad Fatoum wrote: > Despite assigning efi_sys_table->{con_in,con_out} to priv->{in,out}, > some functions still use the global efi_sys_table->{con_in,con_out}. > Let's restrict globals access to the probe function and have the priv > struct completely describe input and output used in the callbacks. > No functional change. > > Signed-off-by: Ahmad Fatoum > --- > drivers/serial/efi-stdio.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox