From: Marco Felsch <m.felsch@pengutronix.de>
To: barebox@lists.infradead.org, p.zabel@pengutronix.de,
enrico.scholz@sigma-chemnitz.de
Subject: [PATCH 2/2] mfd: da9063: fix watchdog ping execution
Date: Wed, 30 Oct 2019 18:06:53 +0100 [thread overview]
Message-ID: <20191030170653.5559-2-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20191030170653.5559-1-m.felsch@pengutronix.de>
The watchdog resets the system if the watchdog gets pinged to fast.
Between each watchdog ping must be a pause of at least 200ms.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
drivers/mfd/da9063.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/mfd/da9063.c b/drivers/mfd/da9063.c
index 4d459c7f18..ab57885240 100644
--- a/drivers/mfd/da9063.c
+++ b/drivers/mfd/da9063.c
@@ -14,6 +14,7 @@
*/
#include <common.h>
+#include <clock.h>
#include <driver.h>
#include <gpio.h>
#include <restart.h>
@@ -33,6 +34,7 @@ struct da9063 {
struct i2c_client *client1;
struct device_d *dev;
unsigned int timeout;
+ uint64_t last_ping;
};
/* forbidden/impossible value; timeout will be set to this value initially to
@@ -237,6 +239,13 @@ static int da9063_watchdog_ping(struct da9063 *priv)
int ret;
u8 val;
+ /* We need to wait at least 200ms till we can resend a ping */
+ if (!is_timeout_non_interruptible(priv->last_ping, 200 * MSECOND)) {
+ dev_dbg(priv->dev, "active ping delay\n");
+ mdelay(50);
+ return da9063_watchdog_ping(priv);
+ }
+
dev_dbg(priv->dev, "ping\n");
/* reset watchdog timer; register is self clearing */
@@ -245,6 +254,8 @@ static int da9063_watchdog_ping(struct da9063 *priv)
if (ret < 0)
return ret;
+ priv->last_ping = get_time_ns();
+
return 0;
}
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-10-30 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 17:06 [PATCH 1/2] mfd: da9063: fix TWDSCALE debug message Marco Felsch
2019-10-30 17:06 ` Marco Felsch [this message]
2019-11-04 8:27 ` [PATCH 2/2] mfd: da9063: fix watchdog ping execution Sascha Hauer
2019-11-04 8:34 ` Marco Felsch
2019-11-04 8:51 ` Ahmad Fatoum
2019-11-04 9:44 ` Marco Felsch
2019-11-04 9:57 ` Ahmad Fatoum
2019-11-04 10:13 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030170653.5559-2-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox