From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: force TEXT_BASE to zero only for relocatable build
Date: Mon, 4 Nov 2019 09:56:07 +0100 [thread overview]
Message-ID: <20191104085607.wscy4t6vdo63set2@pengutronix.de> (raw)
In-Reply-To: <20191101195338.7597-2-dev@lynxeye.de>
On Fri, Nov 01, 2019 at 08:53:38PM +0100, Lucas Stach wrote:
> Commit 2a94e821ba2e (ARM: For relocatable image force TEXT_BASE 0x0)
> intended to force the TEXT_BASE to zero for relocatable images, but
> the change added the Kconfig symbol overriding the TEXT_BASE
> unconditionally. This breaks non-relocatable images.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 652ac24ce3fa..f4e943a8fd8a 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -19,9 +19,11 @@ config ARM_USE_COMPRESSED_DTB
> select UNCOMPRESS
> select LZO_DECOMPRESS
>
> +if RELOCATABLE
> config TEXT_BASE
> hex
> default 0x0
> +endif
Does this really fix something? For example in the
freescale-mx21-ads_defconfig we have CONFIG_TEXT_BASE=0xc3000000 which
is still shown in Kconfig and barebox is correctly built with that TEXT_BASE.
Yes, without this patch we have a duplicate symbol in Kconfig with
concurrent default values, but the files seem to be sourced in the right
order.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-11-04 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 19:53 [PATCH 1/2] ARM: pbl: keep __image_end section Lucas Stach
2019-11-01 19:53 ` [PATCH 2/2] ARM: force TEXT_BASE to zero only for relocatable build Lucas Stach
2019-11-04 8:56 ` Sascha Hauer [this message]
2019-11-04 8:56 ` [PATCH 1/2] ARM: pbl: keep __image_end section Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104085607.wscy4t6vdo63set2@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox