From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] parameter: strip leading and trailing whitespaces
Date: Mon, 4 Nov 2019 10:39:08 +0100 [thread overview]
Message-ID: <20191104093908.feta7vjr65v7nqkn@pengutronix.de> (raw)
In-Reply-To: <20191030170338.29446-1-m.felsch@pengutronix.de>
On Wed, Oct 30, 2019 at 06:03:39PM +0100, Marco Felsch wrote:
> My initial bug was the following: I set the
> global.boot.default="boot1 boot2 " and executed the 'boot' command. If
> both targets are not bootable barebox starts to execute the boot scripts
> found under /env/boot. This is because of the command/boot.c
> implementation and the leading whitespace. Without the whitespace only
> the two desired boot targets are tried.
>
> IMHO leading and trailing whitespaces are error-prone in many cases. If
> someone wants to concatenate strings he/she should add spaces on
> purpose. So I fixed the bug above globally by always stripping leading
> and trailing whitespaces.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> lib/parameter.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-11-04 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 17:03 Marco Felsch
2019-11-04 9:39 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104093908.feta7vjr65v7nqkn@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox