mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] parameter: strip leading and trailing whitespaces
@ 2019-10-30 17:03 Marco Felsch
  2019-11-04  9:39 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Marco Felsch @ 2019-10-30 17:03 UTC (permalink / raw)
  To: barebox

My initial bug was the following: I set the
global.boot.default="boot1 boot2 " and executed the 'boot' command. If
both targets are not bootable barebox starts to execute the boot scripts
found under /env/boot. This is because of the command/boot.c
implementation and the leading whitespace. Without the whitespace only
the two desired boot targets are tried.

IMHO leading and trailing whitespaces are error-prone in many cases. If
someone wants to concatenate strings he/she should add spaces on
purpose. So I fixed the bug above globally by always stripping leading
and trailing whitespaces.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 lib/parameter.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/parameter.c b/lib/parameter.c
index 00e9a9ff4e..fdbb2e71d1 100644
--- a/lib/parameter.c
+++ b/lib/parameter.c
@@ -253,11 +253,14 @@ static int param_string_set(struct device_d *dev, struct param_d *p, const char
 	struct param_string *ps = to_param_string(p);
 	int ret;
 	char *value_save = *ps->value;
+	char *value_new;
 
 	if (!val)
 		val = "";
 
-	*ps->value = xstrdup(val);
+	value_new = xstrdup(val);
+	value_new = strim(value_new);
+	*ps->value = value_new;
 
 	if (!ps->set)
 		return 0;
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-04  9:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 17:03 [PATCH] parameter: strip leading and trailing whitespaces Marco Felsch
2019-11-04  9:39 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox