From: Marco Felsch <m.felsch@pengutronix.de>
To: Robert Karszniewicz <r.karszniewicz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb: storage: Increase retries for usb_stor_transport()
Date: Mon, 4 Nov 2019 16:21:48 +0100 [thread overview]
Message-ID: <20191104152148.ldmh3rrnuvcciksi@pengutronix.de> (raw)
In-Reply-To: <fe9e9928-5b68-c5a1-d6b9-3376e07f0c6e@phytec.de>
Hi Robert,
On 19-11-04 15:59, Robert Karszniewicz wrote:
> On 11/4/19 3:54 PM, Marco Felsch wrote:
> > Hi Sascha,
> >
> > On 19-11-04 10:42, Sascha Hauer wrote:
> > > On Fri, Oct 25, 2019 at 05:56:08PM +0200, Robert Karszniewicz wrote:
> > > > This should make writing and reading more reliable.
> > > >
> > > > Also:
> > > > - change loop condition to make "retries" semantically correct
> > > > - add a debug message in case of fatal failure
> > > > ---
> > > > We've had problems writing (and even reading) a 10 MiB file from barebox
> > > > to multiple USB flash drives.
> > > > The 10 MiB file copy failed with "write: I/O error" almost every time.
> > > > Increasing the retry count made 100 MiB file copies succeed every time.
> > > >
> > >
> > > Doing this doesn't hurt, so I applied this patch. I wonder though if
> > > there's something else wrong which makes increasing the retry counts
> > > necessary.
> > >
> > > Sascha
> >
> > there is a missing sob is that okay with you? Robert can you add a
> > signed-off-by line?
> >
>
> Oops, I'm sorry for that! How do we handle this? Should I just amend and
> resubmit the patch?
Resend as you already did is fine :) else you could reply with your
sob-tag.
Regards,
Marco
> > Regards,
> > Marco
> >
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> >
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-11-04 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 15:56 Robert Karszniewicz
2019-10-25 16:07 ` [PATCH] test: " Robert Karszniewicz
2019-11-04 9:42 ` [PATCH] " Sascha Hauer
2019-11-04 14:52 ` Robert Karszniewicz
2019-11-04 14:54 ` Marco Felsch
2019-11-04 14:59 ` Robert Karszniewicz
2019-11-04 15:21 ` Marco Felsch [this message]
2019-11-04 15:28 ` Robert Karszniewicz
2019-11-04 15:04 ` [PATCH v2] " Robert Karszniewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104152148.ldmh3rrnuvcciksi@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.karszniewicz@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox