[PATCH] param: drop unused parameters in helpers

[PATCH] param: drop unused parameters in helpers

[Ahmad Fatoum]

These parameters aren't currently used anywhere, but are still useful to
have nonetheless. Keep them but drop the unused parameters.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 include/param.h | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/include/param.h b/include/param.h
index bc4370b908a4..bd2f9f67a2b4 100644
--- a/include/param.h
+++ b/include/param.h
@@ -270,8 +270,6 @@ static inline struct param_d *dev_add_param_bool_ro(struct device_d *dev, const
 }
 
 static inline struct param_d *dev_add_param_string_ro(struct device_d *dev, const char *name,
-		int (*set)(struct param_d *p, void *priv),
-		int (*get)(struct param_d *p, void *priv),
 		char **value, void *priv)
 {
 	return dev_add_param_string(dev, name, param_set_readonly, NULL, value, NULL);
@@ -291,9 +289,7 @@ static inline struct param_d *dev_add_param_enum_ro(struct device_d *dev, const
 }
 
 static inline struct param_d *dev_add_param_bitmask_ro(struct device_d *dev, const char *name,
-		int (*set)(struct param_d *p, void *priv),
-		int (*get)(struct param_d *p, void *priv),
-		unsigned long *value, const char * const *names, int max, void *priv)
+		unsigned long *value, const char * const *names, int max)
 {
 	return dev_add_param_bitmask(dev, name, param_set_readonly, NULL,
 				     value, names, max, NULL);
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] param: drop unused parameters in helpers

[Sascha Hauer]

On Mon, Nov 04, 2019 at 06:04:18PM +0100, Ahmad Fatoum wrote:
> These parameters aren't currently used anywhere, but are still useful to
> have nonetheless. Keep them but drop the unused parameters.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  include/param.h | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox