[PATCH 1/2] ARM: i.MX6: Embedsky E9: remove inaccurate comment

[PATCH 1/2] ARM: i.MX6: Embedsky E9: remove inaccurate comment

[Ahmad Fatoum]

The board support is likely copied from the freescale-mx6-sabrelite,
which requires some GPIOs setup before Ethernet is usable. There is no
GPIOs used in this board's code, so remove the comment and along it the
<gpio.h> header.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/boards/embedsky-e9/board.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/boards/embedsky-e9/board.c b/arch/arm/boards/embedsky-e9/board.c
index 0f47677bb06a..e5f92636fbc3 100644
--- a/arch/arm/boards/embedsky-e9/board.c
+++ b/arch/arm/boards/embedsky-e9/board.c
@@ -22,7 +22,6 @@
 #include <init.h>
 #include <environment.h>
 #include <mach/imx6-regs.h>
-#include <gpio.h>
 #include <asm/armlinux.h>
 #include <generated/mach-types.h>
 #include <partition.h>
@@ -102,8 +101,4 @@ static int e9_coredevices_init(void)
 
 	return 0;
 }
-/*
- * Do this before the fec initializes but after our
- * gpios are available.
- */
 coredevice_initcall(e9_coredevices_init);
-- 
2.24.0.rc1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/2] ARM: i.MX6: sabresd: remove inaccurate comment

[Ahmad Fatoum]

The board support is likely copied from the freescale-mx6-sabrelite,
which requires some GPIOs setup before Ethernet is usable. There is no
GPIOs used in this board's code, so remove the comment and along it the
<gpio.h> header.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/boards/freescale-mx6-sabresd/board.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/boards/freescale-mx6-sabresd/board.c b/arch/arm/boards/freescale-mx6-sabresd/board.c
index 595b1eae0ba8..a5059835dfbc 100644
--- a/arch/arm/boards/freescale-mx6-sabresd/board.c
+++ b/arch/arm/boards/freescale-mx6-sabresd/board.c
@@ -19,7 +19,6 @@
 #include <init.h>
 #include <environment.h>
 #include <mach/imx6-regs.h>
-#include <gpio.h>
 #include <asm/armlinux.h>
 #include <generated/mach-types.h>
 #include <partition.h>
@@ -84,8 +83,4 @@ static int sabresd_coredevices_init(void)
 
 	return 0;
 }
-/*
- * Do this before the fec initializes but after our
- * gpios are available.
- */
 coredevice_initcall(sabresd_coredevices_init);
-- 
2.24.0.rc1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/2] ARM: i.MX6: Embedsky E9: remove inaccurate comment

[Sascha Hauer]

On Fri, Nov 08, 2019 at 12:33:01PM +0100, Ahmad Fatoum wrote:
> The board support is likely copied from the freescale-mx6-sabrelite,
> which requires some GPIOs setup before Ethernet is usable. There is no
> GPIOs used in this board's code, so remove the comment and along it the
> <gpio.h> header.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/boards/embedsky-e9/board.c | 5 -----
>  1 file changed, 5 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox