mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <ahmad@a3f.at>
To: barebox@lists.infradead.org
Subject: [PATCH v2 0/3] net: designware: eqos: stop DMA on halt
Date: Fri, 15 Nov 2019 08:32:36 +0100	[thread overview]
Message-ID: <20191115073239.21013-1-ahmad@a3f.at> (raw)
In-Reply-To: <20191112120036.5dghk76prcxsxtjh@pengutronix.de>

I recently learnt that barebox Ethernet drivers need to call ->halt 
themselves, either directly or indirectly.

The first patch does this. Sascha, do you do fixups into master? If so,
you could fix the first commit up into my previous patch.

After applying the patch and doing a round of boot bnet, the first MDIO
access during probe times out:

    ERROR: <NULL>: MDIO not idle at entry

This is fixed by the other two commits.

The driver isn't in a release yet, so I hope they could join the driver
in master.

Cheers
Ahmad

Ahmad Fatoum (3):
  fixup! net: designware: eqos: stop DMA on halt
  net: designware: eqos: enable clocks before mdio_register
  net: designware: eqos: fix NULL pointer use in dev_printf

 drivers/net/designware_eqos.c     | 18 ++++++------
 drivers/net/designware_eqos.h     |  4 ---
 drivers/net/designware_stm32.c    | 33 +---------------------
 drivers/net/designware_tegra186.c | 47 ++++++-------------------------
 4 files changed, 20 insertions(+), 82 deletions(-)

-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-11-15  7:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11  9:56 [PATCH 0/1] " Ahmad Fatoum
2019-11-11  9:56 ` [PATCH 1/1] " Ahmad Fatoum
2019-11-12 12:00   ` Sascha Hauer
2019-11-15  7:32     ` Ahmad Fatoum [this message]
2019-11-15  7:32       ` [PATCH 1/3] net: designware: eqos: properly " Ahmad Fatoum
2019-11-15  7:32       ` [PATCH 2/3] net: designware: eqos: enable clocks before mdio_register Ahmad Fatoum
2019-11-15  7:32       ` [PATCH 3/3] net: designware: eqos: fix NULL pointer use in dev_printf Ahmad Fatoum
2019-11-15 13:41       ` [PATCH v2 0/3] net: designware: eqos: stop DMA on halt Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115073239.21013-1-ahmad@a3f.at \
    --to=ahmad@a3f.at \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox