[PATCH 3/3] remoteproc: add .stop device parameter for stopping remote processor

[Ahmad Fatoum <ahmad@a3f.at>]

Both the STM32 and i.MX7 remote proc drivers populate the .stop member
in the struct rproc, but it's not used anywhere. The firmware API is not
really fitting to 'unload' firmware. Add instead a device parameter to
stop a remote processor, e.g. remoteproc0.stop=1. This is similar to the
probe command used with MMCs.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/remoteproc/remoteproc_core.c | 30 +++++++++++++++++++++++-----
 include/linux/remoteproc.h           |  2 ++
 2 files changed, 27 insertions(+), 5 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 8a28c1bafc1b..e031640bc7a0 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -101,6 +101,8 @@ static int rproc_firmware_finish(struct firmware_handler *fh)
 	fw.size = rproc->fw_buf_ofs;
 
 	ret = rproc_start(rproc, &fw);
+	if (ret == 0)
+		rproc->stop = PARAM_TRISTATE_FALSE;
 
 	kfree(rproc->fw_buf);
 
@@ -120,6 +122,19 @@ static int rproc_register_dev(struct rproc *rproc, const char *alias)
 	return register_device(&rproc->dev);
 }
 
+static int rproc_set_stop(struct param_d *param, void *priv)
+{
+	struct rproc *rproc = priv;
+	int (*stop)(struct rproc *);
+
+	stop = rproc->ops->stop;
+
+	if (!stop)
+		return -ENOSYS;
+
+	return stop(rproc);
+}
+
 int rproc_add(struct rproc *rproc)
 {
 	struct device_d *dev = &rproc->dev;
@@ -142,12 +157,17 @@ int rproc_add(struct rproc *rproc)
 	fh->close = rproc_firmware_finish;
 
 	ret = firmwaremgr_register(fh);
-	if (ret)
-		dev_err(dev, "filed to register firmware handler %s\n", rproc->name);
-	else
-		dev_info(dev, "%s is available\n", rproc->name);
+	if (ret) {
+		dev_err(dev, "failed to register firmware handler %s\n", rproc->name);
+		return ret;
+	}
 
-	return ret;
+	rproc->stop = PARAM_TRISTATE_UNKNOWN;
+	dev_add_param_tristate(&rproc->dev, "stop", rproc_set_stop, NULL,
+			   &rproc->stop, rproc);
+
+	dev_info(dev, "%s is available\n", rproc->name);
+	return 0;
 }
 
 struct rproc *rproc_alloc(struct device_d *dev, const char *name,
diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
index c6264d1c0a49..af35837fb39a 100644
--- a/include/linux/remoteproc.h
+++ b/include/linux/remoteproc.h
@@ -41,6 +41,8 @@ struct rproc {
 
 	void *fw_buf;
 	size_t fw_buf_ofs;
+
+	int stop;
 };
 
 struct rproc *rproc_alloc(struct device_d *dev, const char *name,
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox