From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/8] ARM: Add generic device tree 2nd stage support
Date: Mon, 25 Nov 2019 08:47:45 +0100 [thread overview]
Message-ID: <20191125074744.wbtktsqljwsmmxvz@pengutronix.de> (raw)
In-Reply-To: <27e33ef9-bb89-dcd0-9829-6dd3036eeae9@pengutronix.de>
On Tue, Nov 19, 2019 at 09:26:58AM +0100, Ahmad Fatoum wrote:
> Hello Sascha,
>
> On 8/19/19 3:38 PM, Sascha Hauer wrote:
> > +void dt_2nd_aarch64(void *fdt)
> > +{
> > + unsigned long image_start = (unsigned long)_text + global_variable_offset();
> > +
> > + arm_setup_stack(image_start);
>
> Shouldn't we rather place the stack somewhere beyond the end of the barebox image
> instead of assuming that we can access the memory before the start?
Yes, this should be better. barebox is sometimes loaded directly to the
start of SDRAM.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-11-25 7:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 13:38 [PATCH 0/8] Add support for a generic DT based 2nd stage ARM image Sascha Hauer
2019-08-19 13:38 ` [PATCH 1/8] dtc: Update update-dtc-source.sh from Linux Sascha Hauer
2019-08-19 13:48 ` Roland Hieber
2019-08-19 13:38 ` [PATCH 2/8] scripts/dtc: Update to upstream version v1.5.0 Sascha Hauer
2019-08-19 13:52 ` Roland Hieber
2019-08-19 13:56 ` Sascha Hauer
2019-08-19 14:09 ` Roland Hieber
2019-09-23 13:39 ` Ahmad Fatoum
2019-08-19 13:38 ` [PATCH 3/8] pbl: Implement strrchr Sascha Hauer
2019-08-19 13:38 ` [PATCH 4/8] Compile libfdt for barebox Sascha Hauer
2019-08-19 13:38 ` [PATCH 5/8] common: return "none" when board unset Sascha Hauer
2019-08-19 13:38 ` [PATCH 6/8] ARM: Add generic device tree 2nd stage support Sascha Hauer
2019-11-19 8:26 ` Ahmad Fatoum
2019-11-19 9:41 ` Oleksij Rempel
2019-11-19 10:21 ` Ahmad Fatoum
2019-11-25 7:47 ` Sascha Hauer [this message]
2019-08-19 13:38 ` [PATCH 7/8] ARM: i.MX: Do not hang() on unknown SoCs Sascha Hauer
2019-08-19 13:38 ` [PATCH 8/8] ARM: i.MX: When generic DT image is enabled do not hardcode SoC Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125074744.wbtktsqljwsmmxvz@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox