From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mci: dove: fix dereference of nullable pointer
Date: Mon, 25 Nov 2019 08:59:31 +0100 [thread overview]
Message-ID: <20191125075931.5jokmmwvvepk5riz@pengutronix.de> (raw)
In-Reply-To: <20191120073816.16119-1-ahmad@a3f.at>
On Wed, Nov 20, 2019 at 08:38:16AM +0100, Ahmad Fatoum wrote:
> data->{blocks, blocksize, flags} are all used outside of the if clause
> checking whether data is not NULL.
> Fix this to avoid dereferencing null pointers.
>
> Fixes: bdcf89d274 ("mci: add Marvell Dove SDHCI driver")
> Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> drivers/mci/dove-sdhci.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-11-25 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 7:38 Ahmad Fatoum
2019-11-25 7:59 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125075931.5jokmmwvvepk5riz@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox