From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZxWM-0006zj-13 for barebox@lists.infradead.org; Wed, 27 Nov 2019 13:38:19 +0000 Date: Wed, 27 Nov 2019 14:38:15 +0100 From: Sascha Hauer Message-ID: <20191127133815.27h2lz2sdo42tfnm@pengutronix.de> References: <20191127111613.24173-1-s.hauer@pengutronix.de> <20191127111613.24173-4-s.hauer@pengutronix.de> <153bbae3-b43b-558e-900f-462f2c60b2f8@pengutronix.de> <20191127123218.3dbjdf7xti5iqai2@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/4] of/gpio: Support gpio-line-names property To: Ahmad Fatoum Cc: barebox@lists.infradead.org On Wed, Nov 27, 2019 at 01:35:21PM +0100, Ahmad Fatoum wrote: > Hello Sascha, > > On 11/27/19 1:32 PM, Sascha Hauer wrote: > > barebox contains functions and commands to change and delete properties > > and nodes. We shouldn't store pointers into the live tree anywhere. > > aren't these fixups done just before boot? Yes. > What users change the live device tree? We already had problems with users deleting nodes that were referenced at other places. I'm not saying this is wise to do so, but it happened. It might be a good idea to separate the live tree from the one the user actually sees, but then again things like of_device_enable_path() and of_device_enable_and_register_by_name() wouldn't work anymore. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox