[PATCH 00/39] randcfg build fixes

[PATCH 00/39] randcfg build fixes

[Lucas Stach]

Hi,

this series is a set of fixes that have accumulated in the randcfg
build tests. All of them survived serveral rounds of build testing
without causing any new issues. Not all of them fix build breakages,
a significant number is just fixing compiler warnings that showed
up in the build jobs.

Regards,
Lucas

Lucas Stach (39):
  ARM: imx: add image type choice
  ratp: add more build dependencies
  ARM: move into ARM32 specific optee kernel start into lib32 dir
  ARM: implement CONFIG_PBL_BREAK for ARM64
  lib: zstd: declare locally used functions as static
  common: provide stubs for ctrlc_* functions
  commands: keystore: use correct type for s_len
  gui: picopng: declare locally used functions as static
  reset_source: add stub for reset_source_set_device
  spi: fix symbol export for spi_register_controller
  mfd: superio: add missing semicolon after EXPORT_SYMBOL
  ARM: psci: declare locally used functions as static
  ARM: mxs: bcb: declare locally used functions as static
  usb: dwc3: depend on OFDEVICE
  mtd: nand: don't call BBT functions if BBT support isn't built
  mfd: da9063: don't try to register gpiochip when GPIOLIB isn't built
  mci: MCI_IMX_ESDHC_PBL has no dependency on MCI
  i2c: always walk down into i2c/busses Makefile
  usb: usb251xb: depend on OFDEVICE
  pstore: don't try to grab non-existent logbuf
  firmware: zynqmp-fpga: fix comparison between pointer and integer
  pstore: ramoops: use correct format specifier for size_t variables
  clocksource: ARMv8 timer can only be built on ARMv8
  input: select POLLER
  ARM: layerscape: add missing selects for TQMLS1046A
  ARM: PBL break is not available on ARMv4
  ARM: ARM_SMCCC is only available on >= ARMv7
  ARM: layerscape: select OFTREE and OFDEVICE
  usb: dwc3: dual role mode needs gadget support
  pinctrl: at91pio4: move to correct location in Kconfig
  ARM: layerscape: ppa: use sync_for_execution instead of a manual cache
    flush
  ubootvarfs: depend on OFTREE
  ARM: davinci: virt2real: select OFTREE and OFDEVICE
  ARM: omap: pfc200: NAND support requires CONFIG_OMAP_GPMC
  net: designware-eqos: depend on COMMON_CLK
  ARM: mvebu: correct DTB rule for MARVELL_ARMADA_XP_DB
  nvme: correct symbol export name for nvme_submit_sync_cmd
  pinctrl: tegra: mark drvdata as maybe unused
  pinctrl: at91pio4 depends on OFDEVICE

 arch/arm/Kconfig                             |  4 ++
 arch/arm/boards/wago-pfc-am35xx/board-mlo.c  |  4 +-
 arch/arm/cpu/Makefile                        |  1 -
 arch/arm/cpu/common.c                        |  4 ++
 arch/arm/cpu/psci.c                          |  2 +-
 arch/arm/dts/Makefile                        |  3 +-
 arch/arm/include/asm/barebox-arm-head.h      |  4 ++
 arch/arm/lib32/Makefile                      |  1 +
 arch/arm/{cpu => lib32}/start-kernel-optee.S |  0
 arch/arm/mach-at91/Kconfig                   |  1 +
 arch/arm/mach-davinci/Kconfig                |  2 +
 arch/arm/mach-imx/Kconfig                    | 56 +++++++++++-------
 arch/arm/mach-layerscape/Kconfig             |  3 +
 arch/arm/mach-layerscape/ppa.c               |  4 +-
 arch/arm/mach-mxs/bcb.c                      |  2 +-
 commands/keystore.c                          |  2 +-
 common/Kconfig                               |  2 +-
 common/console_simple.c                      | 11 ----
 common/ratp/Kconfig                          |  1 +
 drivers/Makefile                             |  4 +-
 drivers/clocksource/Kconfig                  |  2 +-
 drivers/firmware/zynqmp-fpga.c               |  2 +-
 drivers/i2c/Makefile                         |  3 +-
 drivers/input/Kconfig                        |  1 +
 drivers/mci/Kconfig                          |  6 +-
 drivers/mfd/da9063.c                         | 16 +++---
 drivers/mfd/superio.c                        |  4 +-
 drivers/misc/Kconfig                         |  1 +
 drivers/mtd/nand/nand_base.c                 |  4 +-
 drivers/net/Kconfig                          |  3 +-
 drivers/nvme/host/core.c                     |  2 +-
 drivers/pinctrl/Kconfig                      | 20 +++----
 drivers/pinctrl/pinctrl-tegra30.c            |  4 +-
 drivers/spi/spi.c                            |  2 +-
 drivers/usb/dwc3/Kconfig                     |  2 +
 drivers/usb/misc/Kconfig                     |  1 +
 fs/pstore/platform.c                         |  3 +
 fs/pstore/ram.c                              |  8 +--
 include/common.h                             |  5 ++
 include/console.h                            |  5 ++
 include/reset_source.h                       |  5 ++
 lib/Kconfig                                  |  5 ++
 lib/gui/picopng.c                            | 60 ++++++++++----------
 lib/zstd/decompress.c                        | 10 ++--
 44 files changed, 171 insertions(+), 114 deletions(-)
 rename arch/arm/{cpu => lib32}/start-kernel-optee.S (100%)

-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 01/39] ARM: imx: add image type choice

[Lucas Stach]

ARM32 and ARM64 boards can not be built into the same image. Make this
clear by adding a choice for the different image types. While at it
add a single board option.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-imx/Kconfig | 56 +++++++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 20 deletions(-)

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 6e98e95dbb00..f39d58ecefb2 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -199,10 +199,22 @@ config ARCH_VF610
 	select IMX_OCOTP	# Needed for clock adjustement
 	select CLOCKSOURCE_ARM_GLOBAL_TIMER
 
+choice
+	prompt "Build type"
+
 config IMX_MULTI_BOARDS
-	bool "Allow multiple boards to be selected"
+	bool "Allow multiple ARM32 boards to be selected"
+	select HAVE_PBL_MULTI_IMAGES
+
+config IMX_MULTI_BOARDS64
+	bool "Allow multiple ARM64 boards to be selected"
 	select HAVE_PBL_MULTI_IMAGES
 
+config IMX_SINGLE_BOARD
+	bool "Select single board (legacy)"
+
+endchoice
+
 if IMX_MULTI_BOARDS
 
 config MACH_SCB9328
@@ -461,16 +473,6 @@ config MACH_ZII_RDU2
 	select MACH_ZII_COMMON
 	select ARM_USE_COMPRESSED_DTB
 
-config MACH_ZII_IMX8MQ_DEV
-	bool "ZII i.MX8MQ based devices"
-	select ARCH_IMX8MQ
-	select FIRMWARE_IMX_LPDDR4_PMU_TRAIN
-	select FIRMWARE_IMX8MQ_ATF
-	select ARM_SMCCC
-	select MCI_IMX_ESDHC_PBL
-	select MACH_ZII_COMMON
-	select ARM_USE_COMPRESSED_DTB
-
 config MACH_ZII_VF610_DEV
 	bool "ZII VF610 Dev Family"
 	select ARCH_VF610
@@ -502,6 +504,20 @@ config MACH_NXP_IMX6ULL_EVK
 	bool "NXP i.MX6ull EVK Board"
 	select ARCH_IMX6UL
 
+config MACH_GRINN_LITEBOARD
+	bool "Grinn liteboard"
+	select ARCH_IMX6UL
+
+config MACH_DIGI_CCIMX6ULSBCPRO
+	bool "Digi Internal CC-IMX6UL SBC Pro"
+	select ARCH_IMX6
+	select ARCH_IMX6UL
+	select ARM_USE_COMPRESSED_DTB
+
+endif
+
+if IMX_MULTI_BOARDS64
+
 config MACH_NXP_IMX8MQ_EVK
 	bool "NXP i.MX8MQ EVK Board"
 	select ARCH_IMX8MQ
@@ -518,14 +534,14 @@ config MACH_PHYTEC_SOM_IMX8MQ
 	select ARM_SMCCC
 	select MCI_IMX_ESDHC_PBL
 
-config MACH_GRINN_LITEBOARD
-	bool "Grinn liteboard"
-	select ARCH_IMX6UL
-
-config MACH_DIGI_CCIMX6ULSBCPRO
-	bool "Digi Internal CC-IMX6UL SBC Pro"
-	select ARCH_IMX6
-	select ARCH_IMX6UL
+config MACH_ZII_IMX8MQ_DEV
+	bool "ZII i.MX8MQ based devices"
+	select ARCH_IMX8MQ
+	select FIRMWARE_IMX_LPDDR4_PMU_TRAIN
+	select FIRMWARE_IMX8MQ_ATF
+	select ARM_SMCCC
+	select MCI_IMX_ESDHC_PBL
+	select MACH_ZII_COMMON
 	select ARM_USE_COMPRESSED_DTB
 
 endif
@@ -534,7 +550,7 @@ endif
 
 choice
 	prompt "Select Board"
-	depends on !IMX_MULTI_BOARDS
+	depends on IMX_SINGLE_BOARD
 
 # ----------------------------------------------------------
 
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 02/39] ratp: add more build dependencies

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 common/ratp/Kconfig | 1 +
 lib/Kconfig         | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/common/ratp/Kconfig b/common/ratp/Kconfig
index 30462c6c9759..25150addfd75 100644
--- a/common/ratp/Kconfig
+++ b/common/ratp/Kconfig
@@ -6,6 +6,7 @@ config CONSOLE_RATP
 	select POLLER
 	select CMDLINE_EDITING
 	depends on CONSOLE_FULL
+	depends on !SHELL_NONE
 	prompt "RATP console support"
 	help
 	  This option adds support for remote controlling barebox via serial
diff --git a/lib/Kconfig b/lib/Kconfig
index 6216fdd6bac0..9a80780186a5 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -105,6 +105,11 @@ config LIBFDT
 
 config RATP
 	select CRC_ITU_T
+	select COMPILE_MEMORY
+	select COMMAND_SUPPORT
+	select POLLER
+	depends on CONSOLE_FULL
+	depends on !SHELL_NONE
 	bool "RATP protocol support"
 	help
 	  Reliable Asynchronous Transfer Protocol (RATP) is a protocol for reliably
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 03/39] ARM: move into ARM32 specific optee kernel start into lib32 dir

[Lucas Stach]

Otherwise it may also get built on a ARM64 config, which obviously
fails.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/cpu/Makefile                        | 1 -
 arch/arm/lib32/Makefile                      | 1 +
 arch/arm/{cpu => lib32}/start-kernel-optee.S | 0
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename arch/arm/{cpu => lib32}/start-kernel-optee.S (100%)

diff --git a/arch/arm/cpu/Makefile b/arch/arm/cpu/Makefile
index 09b3bc2eeab9..4b6e2384973e 100644
--- a/arch/arm/cpu/Makefile
+++ b/arch/arm/cpu/Makefile
@@ -15,7 +15,6 @@ pbl-$(CONFIG_BOARD_ARM_GENERIC_DT_AARCH64) += board-dt-2nd-aarch64.o
 
 obj-pbl-y += setupc$(S64).o cache$(S64).o
 
-obj-$(CONFIG_BOOTM_OPTEE) += start-kernel-optee.o
 obj-$(CONFIG_ARM_PSCI_CLIENT) += psci-client.o
 
 #
diff --git a/arch/arm/lib32/Makefile b/arch/arm/lib32/Makefile
index 3c02a0bf96d7..cd43147e662a 100644
--- a/arch/arm/lib32/Makefile
+++ b/arch/arm/lib32/Makefile
@@ -1,6 +1,7 @@
 obj-$(CONFIG_ARM_LINUX)	+= armlinux.o
 obj-$(CONFIG_CMD_BOOTZ)	+= bootz.o
 obj-$(CONFIG_BOOTM)     += bootm.o
+obj-$(CONFIG_BOOTM_OPTEE) += start-kernel-optee.o
 obj-$(CONFIG_CMD_BOOTU) += bootu.o
 obj-y	+= div0.o
 obj-y	+= findbit.o
diff --git a/arch/arm/cpu/start-kernel-optee.S b/arch/arm/lib32/start-kernel-optee.S
similarity index 100%
rename from arch/arm/cpu/start-kernel-optee.S
rename to arch/arm/lib32/start-kernel-optee.S
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 04/39] ARM: implement CONFIG_PBL_BREAK for ARM64

[Lucas Stach]

ARM64 uses a different assembler mnemonic for the breakpoint.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/cpu/common.c                   | 4 ++++
 arch/arm/include/asm/barebox-arm-head.h | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm/cpu/common.c b/arch/arm/cpu/common.c
index c81b2b37912e..c7d1709b8bed 100644
--- a/arch/arm/cpu/common.c
+++ b/arch/arm/cpu/common.c
@@ -51,7 +51,11 @@ void pbl_barebox_break(void)
 {
 	__asm__ __volatile__ (
 #ifdef CONFIG_PBL_BREAK
+#ifdef CONFIG_CPU_V8
+		"brk #17\n"
+#else
 		"bkpt #17\n"
+#endif
 		"nop\n"
 #else
 		"nop\n"
diff --git a/arch/arm/include/asm/barebox-arm-head.h b/arch/arm/include/asm/barebox-arm-head.h
index 83a22c4d94c3..8409a77d2e7c 100644
--- a/arch/arm/include/asm/barebox-arm-head.h
+++ b/arch/arm/include/asm/barebox-arm-head.h
@@ -65,7 +65,11 @@ static inline void __barebox_arm_head(void)
 		".endr\n"
 		"2:\n"
 #ifdef CONFIG_PBL_BREAK
+#ifdef CONFIG_CPU_V8
+		"brk #17\n"
+#else
 		"bkpt #17\n"
+#endif
 		"nop\n"
 #else
 		"nop\n"
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 05/39] lib: zstd: declare locally used functions as static

[Lucas Stach]

Fixes "no previous prototype for...) warnings in the zstd code.

Fixes: 1a39d4dcbffc (lib: Add zstd decompression module)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 lib/zstd/decompress.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/zstd/decompress.c b/lib/zstd/decompress.c
index 8203b815caf4..19bf71288111 100644
--- a/lib/zstd/decompress.c
+++ b/lib/zstd/decompress.c
@@ -123,7 +123,7 @@ size_t ZSTD_decompressBegin(ZSTD_DCtx *dctx)
 	return 0;
 }
 
-ZSTD_DCtx *ZSTD_createDCtx_advanced(ZSTD_customMem customMem)
+static ZSTD_DCtx *ZSTD_createDCtx_advanced(ZSTD_customMem customMem)
 {
 	ZSTD_DCtx *dctx;
 
@@ -391,7 +391,7 @@ typedef struct {
 
 /*! ZSTD_getcBlockSize() :
 *   Provides the size of compressed block from block header `src` */
-size_t ZSTD_getcBlockSize(const void *src, size_t srcSize, blockProperties_t *bpPtr)
+static size_t ZSTD_getcBlockSize(const void *src, size_t srcSize, blockProperties_t *bpPtr)
 {
 	if (srcSize < ZSTD_blockHeaderSize)
 		return ERROR(srcSize_wrong);
@@ -429,7 +429,7 @@ static size_t ZSTD_setRleBlock(void *dst, size_t dstCapacity, const void *src, s
 
 /*! ZSTD_decodeLiteralsBlock() :
 	@return : nb of bytes read from src (< srcSize ) */
-size_t ZSTD_decodeLiteralsBlock(ZSTD_DCtx *dctx, const void *src, size_t srcSize) /* note : srcSize < BLOCKSIZE */
+static size_t ZSTD_decodeLiteralsBlock(ZSTD_DCtx *dctx, const void *src, size_t srcSize) /* note : srcSize < BLOCKSIZE */
 {
 	if (srcSize < MIN_CBLOCK_SIZE)
 		return ERROR(corruption_detected);
@@ -791,7 +791,7 @@ static size_t ZSTD_buildSeqTable(FSE_DTable *DTableSpace, const FSE_DTable **DTa
 	}
 }
 
-size_t ZSTD_decodeSeqHeaders(ZSTD_DCtx *dctx, int *nbSeqPtr, const void *src, size_t srcSize)
+static size_t ZSTD_decodeSeqHeaders(ZSTD_DCtx *dctx, int *nbSeqPtr, const void *src, size_t srcSize)
 {
 	const BYTE *const istart = (const BYTE *const)src;
 	const BYTE *const iend = istart + srcSize;
@@ -1494,7 +1494,7 @@ size_t ZSTD_insertBlock(ZSTD_DCtx *dctx, const void *blockStart, size_t blockSiz
 	return blockSize;
 }
 
-size_t ZSTD_generateNxBytes(void *dst, size_t dstCapacity, BYTE byte, size_t length)
+static size_t ZSTD_generateNxBytes(void *dst, size_t dstCapacity, BYTE byte, size_t length)
 {
 	if (length > dstCapacity)
 		return ERROR(dstSize_tooSmall);
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 06/39] common: provide stubs for ctrlc_* functions

[Lucas Stach]

Currently the stubs are only provided for CONFIG_CONSOLE_SIMPLE, but
they are also needed for CONSOLE_NONE. Move them to the header.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 common/console_simple.c | 11 -----------
 include/common.h        |  5 +++++
 include/console.h       |  5 +++++
 3 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/common/console_simple.c b/common/console_simple.c
index 6d293b2ba109..42224842c5ea 100644
--- a/common/console_simple.c
+++ b/common/console_simple.c
@@ -64,9 +64,6 @@ void console_flush(void)
 }
 EXPORT_SYMBOL(console_flush);
 
-void ctrlc_handled(void)
-{
-}
 /* test if ctrl-c was pressed */
 int ctrlc (void)
 {
@@ -81,14 +78,6 @@ int ctrlc (void)
 }
 EXPORT_SYMBOL(ctrlc);
 
-void console_ctrlc_allow(void)
-{
-}
-
-void console_ctrlc_forbid(void)
-{
-}
-
 int console_register(struct console_device *newcdev)
 {
 	if (console)
diff --git a/include/common.h b/include/common.h
index 65630684678c..c6eb50420f68 100644
--- a/include/common.h
+++ b/include/common.h
@@ -68,7 +68,12 @@ long	get_ram_size  (volatile long *, long);
 /* common/console.c */
 int ctrlc(void);
 int arch_ctrlc(void);
+
+#ifdef CONFIG_CONSOLE_FULL
 void ctrlc_handled(void);
+#else
+static inline void ctrlc_handled(void) { }
+#endif
 
 #ifdef CONFIG_ARCH_HAS_STACK_DUMP
 void dump_stack(void);
diff --git a/include/console.h b/include/console.h
index 7afe59e93a27..537ac97ab34d 100644
--- a/include/console.h
+++ b/include/console.h
@@ -207,7 +207,12 @@ static inline void pbl_set_putc(void (*putcf)(void *ctx, int c), void *ctx) {}
 
 bool console_allow_color(void);
 
+#ifdef CONFIG_CONSOLE_FULL
 void console_ctrlc_allow(void);
 void console_ctrlc_forbid(void);
+#else
+static inline void console_ctrlc_allow(void) { }
+static inline void console_ctrlc_forbid(void) { }
+#endif
 
 #endif
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 07/39] commands: keystore: use correct type for s_len

[Lucas Stach]

Fixes the follwing warning: "passing argument 2 of 'read_file_2'
from incompatible pointer type".

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 commands/keystore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/keystore.c b/commands/keystore.c
index 52c4be263974..4f6a7ef190ea 100644
--- a/commands/keystore.c
+++ b/commands/keystore.c
@@ -15,7 +15,7 @@ static int do_keystore(int argc, char *argv[])
 	const char *file = NULL;
 	char *secret_str = NULL;
 	void *secret;
-	int s_len;
+	size_t s_len;
 
 	while ((opt = getopt(argc, argv, "rs:f:")) > 0) {
 		switch (opt) {
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 08/39] gui: picopng: declare locally used functions as static

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 lib/gui/picopng.c | 60 +++++++++++++++++++++++------------------------
 1 file changed, 30 insertions(+), 30 deletions(-)

diff --git a/lib/gui/picopng.c b/lib/gui/picopng.c
index ad44efa689be..80f03beb68a9 100644
--- a/lib/gui/picopng.c
+++ b/lib/gui/picopng.c
@@ -32,7 +32,7 @@ typedef struct png_alloc_node {
 png_alloc_node_t *png_alloc_head = NULL;
 png_alloc_node_t *png_alloc_tail = NULL;
 
-png_alloc_node_t *png_alloc_find_node(void *addr)
+static png_alloc_node_t *png_alloc_find_node(void *addr)
 {
 	png_alloc_node_t *node;
 	for (node = png_alloc_head; node; node = node->next)
@@ -41,7 +41,7 @@ png_alloc_node_t *png_alloc_find_node(void *addr)
 	return node;
 }
 
-void png_alloc_add_node(void *addr, size_t size)
+static void png_alloc_add_node(void *addr, size_t size)
 {
 	png_alloc_node_t *node;
 	if (png_alloc_find_node(addr))
@@ -58,7 +58,7 @@ void png_alloc_add_node(void *addr, size_t size)
 		png_alloc_head = node;
 }
 
-void png_alloc_remove_node(png_alloc_node_t *node)
+static void png_alloc_remove_node(png_alloc_node_t *node)
 {
 	if (node->prev)
 		node->prev->next = node->next;
@@ -72,14 +72,14 @@ void png_alloc_remove_node(png_alloc_node_t *node)
 	free(node);
 }
 
-void *png_alloc_malloc(size_t size)
+static void *png_alloc_malloc(size_t size)
 {
 	void *addr = malloc(size);
 	png_alloc_add_node(addr, size);
 	return addr;
 }
 
-void *png_alloc_realloc(void *addr, size_t size)
+static void *png_alloc_realloc(void *addr, size_t size)
 {
 	void *new_addr;
 	if (!addr)
@@ -94,7 +94,7 @@ void *png_alloc_realloc(void *addr, size_t size)
 	return new_addr;
 }
 
-void png_alloc_free(void *addr)
+static void png_alloc_free(void *addr)
 {
 	png_alloc_node_t *node = png_alloc_find_node(addr);
 	if (!node)
@@ -114,7 +114,7 @@ void png_alloc_free_all()
 
 /*************************************************************************************************/
 
-__maybe_unused void vector32_cleanup(vector32_t *p)
+__maybe_unused static void vector32_cleanup(vector32_t *p)
 {
 	p->size = p->allocsize = 0;
 	if (p->data)
@@ -122,7 +122,7 @@ __maybe_unused void vector32_cleanup(vector32_t *p)
 	p->data = NULL;
 }
 
-uint32_t vector32_resize(vector32_t *p, size_t size)
+static uint32_t vector32_resize(vector32_t *p, size_t size)
 {	// returns 1 if success, 0 if failure ==> nothing done
 	if (size * sizeof (uint32_t) > p->allocsize) {
 		size_t newsize = size * sizeof (uint32_t) * 2;
@@ -138,7 +138,7 @@ uint32_t vector32_resize(vector32_t *p, size_t size)
 	return 1;
 }
 
-uint32_t vector32_resizev(vector32_t *p, size_t size, uint32_t value)
+static uint32_t vector32_resizev(vector32_t *p, size_t size, uint32_t value)
 {	// resize and give all new elements the value
 	size_t oldsize = p->size, i;
 	if (!vector32_resize(p, size))
@@ -148,13 +148,13 @@ uint32_t vector32_resizev(vector32_t *p, size_t size, uint32_t value)
 	return 1;
 }
 
-void vector32_init(vector32_t *p)
+static void vector32_init(vector32_t *p)
 {
 	p->data = NULL;
 	p->size = p->allocsize = 0;
 }
 
-vector32_t *vector32_new(size_t size, uint32_t value)
+__maybe_unused static vector32_t *vector32_new(size_t size, uint32_t value)
 {
 	vector32_t *p = png_alloc_malloc(sizeof (vector32_t));
 	vector32_init(p);
@@ -165,7 +165,7 @@ vector32_t *vector32_new(size_t size, uint32_t value)
 
 /*************************************************************************************************/
 
-__maybe_unused void vector8_cleanup(vector8_t *p)
+__maybe_unused static void vector8_cleanup(vector8_t *p)
 {
 	p->size = p->allocsize = 0;
 	if (p->data)
@@ -173,7 +173,7 @@ __maybe_unused void vector8_cleanup(vector8_t *p)
 	p->data = NULL;
 }
 
-uint32_t vector8_resize(vector8_t *p, size_t size)
+static uint32_t vector8_resize(vector8_t *p, size_t size)
 {	// returns 1 if success, 0 if failure ==> nothing done
 	// xxx: the use of sizeof uint32_t here seems like a bug (this descends from the lodepng vector
 	// compatibility functions which do the same). without this there is corruption in certain cases,
@@ -192,7 +192,7 @@ uint32_t vector8_resize(vector8_t *p, size_t size)
 	return 1;
 }
 
-uint32_t vector8_resizev(vector8_t *p, size_t size, uint8_t value)
+static uint32_t vector8_resizev(vector8_t *p, size_t size, uint8_t value)
 {	// resize and give all new elements the value
 	size_t oldsize = p->size, i;
 	if (!vector8_resize(p, size))
@@ -202,13 +202,13 @@ uint32_t vector8_resizev(vector8_t *p, size_t size, uint8_t value)
 	return 1;
 }
 
-void vector8_init(vector8_t *p)
+static void vector8_init(vector8_t *p)
 {
 	p->data = NULL;
 	p->size = p->allocsize = 0;
 }
 
-vector8_t *vector8_new(size_t size, uint8_t value)
+static vector8_t *vector8_new(size_t size, uint8_t value)
 {
 	vector8_t *p = png_alloc_malloc(sizeof (vector8_t));
 	vector8_init(p);
@@ -217,7 +217,7 @@ vector8_t *vector8_new(size_t size, uint8_t value)
 	return p;
 }
 
-vector8_t *vector8_copy(vector8_t *p)
+static vector8_t *vector8_copy(vector8_t *p)
 {
 	vector8_t *q = vector8_new(p->size, 0);
 	uint32_t n;
@@ -227,7 +227,7 @@ vector8_t *vector8_copy(vector8_t *p)
 }
 
 /*************************************************************************************************/
-int Zlib_decompress(vector8_t *out, const vector8_t *in) // returns error value
+static int Zlib_decompress(vector8_t *out, const vector8_t *in) // returns error value
 {
 	return picopng_zlib_decompress(out->data, out->size, in->data, in->size);
 }
@@ -244,14 +244,14 @@ int Zlib_decompress(vector8_t *out, const vector8_t *in) // returns error value
 
 int PNG_error;
 
-uint32_t PNG_readBitFromReversedStream(size_t *bitp, const uint8_t *bits)
+static uint32_t PNG_readBitFromReversedStream(size_t *bitp, const uint8_t *bits)
 {
 	uint32_t result = (bits[*bitp >> 3] >> (7 - (*bitp & 0x7))) & 1;
 	(*bitp)++;
 	return result;
 }
 
-uint32_t PNG_readBitsFromReversedStream(size_t *bitp, const uint8_t *bits, uint32_t nbits)
+static uint32_t PNG_readBitsFromReversedStream(size_t *bitp, const uint8_t *bits, uint32_t nbits)
 {
 	uint32_t i, result = 0;
 	for (i = nbits - 1; i < nbits; i--)
@@ -259,18 +259,18 @@ uint32_t PNG_readBitsFromReversedStream(size_t *bitp, const uint8_t *bits, uint3
 	return result;
 }
 
-void PNG_setBitOfReversedStream(size_t *bitp, uint8_t *bits, uint32_t bit)
+static void PNG_setBitOfReversedStream(size_t *bitp, uint8_t *bits, uint32_t bit)
 {
 	bits[*bitp >> 3] |= (bit << (7 - (*bitp & 0x7)));
 	(*bitp)++;
 }
 
-uint32_t PNG_read32bitInt(const uint8_t *buffer)
+static uint32_t PNG_read32bitInt(const uint8_t *buffer)
 {
 	return (buffer[0] << 24) | (buffer[1] << 16) | (buffer[2] << 8) | buffer[3];
 }
 
-int PNG_checkColorValidity(uint32_t colorType, uint32_t bd) // return type is a LodePNG error code
+static int PNG_checkColorValidity(uint32_t colorType, uint32_t bd) // return type is a LodePNG error code
 {
 	if ((colorType == 2 || colorType == 4 || colorType == 6)) {
 		if (!(bd == 8 || bd == 16))
@@ -291,7 +291,7 @@ int PNG_checkColorValidity(uint32_t colorType, uint32_t bd) // return type is a
 		return 31; // nonexistent color type
 }
 
-uint32_t PNG_getBpp(const PNG_info_t *info)
+static uint32_t PNG_getBpp(const PNG_info_t *info)
 {
 	uint32_t bitDepth, colorType;
 	bitDepth = info->bitDepth;
@@ -304,7 +304,7 @@ uint32_t PNG_getBpp(const PNG_info_t *info)
 		return bitDepth;
 }
 
-void PNG_readPngHeader(PNG_info_t *info, const uint8_t *in, size_t inlength)
+static void PNG_readPngHeader(PNG_info_t *info, const uint8_t *in, size_t inlength)
 {	// read the information from the header and store it in the Info
 	if (inlength < 29) {
 		PNG_error = 27; // error: the data length is smaller than the length of the header
@@ -340,7 +340,7 @@ void PNG_readPngHeader(PNG_info_t *info, const uint8_t *in, size_t inlength)
 	PNG_error = PNG_checkColorValidity(info->colorType, info->bitDepth);
 }
 
-int PNG_paethPredictor(int a, int b, int c) // Paeth predicter, used by PNG filter type 4
+static int PNG_paethPredictor(int a, int b, int c) // Paeth predicter, used by PNG filter type 4
 {
 	int p, pa, pb, pc;
 	p = a + b - c;
@@ -350,7 +350,7 @@ int PNG_paethPredictor(int a, int b, int c) // Paeth predicter, used by PNG filt
 	return (pa <= pb && pa <= pc) ? a : (pb <= pc ? b : c);
 }
 
-void PNG_unFilterScanline(uint8_t *recon, const uint8_t *scanline, const uint8_t *precon,
+static void PNG_unFilterScanline(uint8_t *recon, const uint8_t *scanline, const uint8_t *precon,
 		size_t bytewidth, uint32_t filterType, size_t length)
 {
 	size_t i;
@@ -406,7 +406,7 @@ void PNG_unFilterScanline(uint8_t *recon, const uint8_t *scanline, const uint8_t
 	}
 }
 
-void PNG_adam7Pass(uint8_t *out, uint8_t *linen, uint8_t *lineo, const uint8_t *in, uint32_t w,
+static void PNG_adam7Pass(uint8_t *out, uint8_t *linen, uint8_t *lineo, const uint8_t *in, uint32_t w,
 		size_t passleft, size_t passtop, size_t spacex, size_t spacey, size_t passw, size_t passh,
 		uint32_t bpp)
 {
@@ -446,7 +446,7 @@ void PNG_adam7Pass(uint8_t *out, uint8_t *linen, uint8_t *lineo, const uint8_t *
 	}
 }
 
-int PNG_convert(const PNG_info_t *info, vector8_t *out, const uint8_t *in)
+static int PNG_convert(const PNG_info_t *info, vector8_t *out, const uint8_t *in)
 {	// converts from any color type to 32-bit. return value = LodePNG error code
 	size_t i, c;
 	uint32_t bitDepth, colorType;
@@ -530,7 +530,7 @@ int PNG_convert(const PNG_info_t *info, vector8_t *out, const uint8_t *in)
 	return 0;
 }
 
-PNG_info_t *PNG_info_new(void)
+static PNG_info_t *PNG_info_new(void)
 {
 	PNG_info_t *info = png_alloc_malloc(sizeof (PNG_info_t));
 	uint32_t i;
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 09/39] reset_source: add stub for reset_source_set_device

[Lucas Stach]

Fixes: a0748840c104 (reset_source: implement helper to set a
       device as reset source)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 include/reset_source.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/reset_source.h b/include/reset_source.h
index 3ccd529fdd42..305dde0102d5 100644
--- a/include/reset_source.h
+++ b/include/reset_source.h
@@ -60,6 +60,11 @@ static inline struct device_d *reset_source_get_device(void)
 	return NULL;
 }
 
+static inline void reset_source_set_device(struct device_d *dev,
+					   enum reset_src_type st)
+{
+}
+
 static inline void reset_source_set_prinst(enum reset_src_type type,
 					   unsigned int priority, int instance)
 {
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 10/39] spi: fix symbol export for spi_register_controller

[Lucas Stach]

Fixes: 812a9ddcdf21 (spi: Generalize SPI "master" to "controller")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/spi/spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index d9311d4af508..bd615b4e99c8 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -283,7 +283,7 @@ int spi_register_controller(struct spi_controller *ctrl)
 
 	return status;
 }
-EXPORT_SYMBOL(spi_register_ctrl);
+EXPORT_SYMBOL(spi_register_controller);
 
 struct spi_controller *spi_get_controller(int bus)
 {
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 11/39] mfd: superio: add missing semicolon after EXPORT_SYMBOL

[Lucas Stach]

Fixes: efd517c35f12 (mfd: add basic Super I/O chip helpers)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/mfd/superio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/superio.c b/drivers/mfd/superio.c
index 12d74b40f6f8..ab94a4fa8f75 100644
--- a/drivers/mfd/superio.c
+++ b/drivers/mfd/superio.c
@@ -24,7 +24,7 @@ struct device_d *superio_func_add(struct superio_chip *siochip, const char *name
 
 	return dev;
 }
-EXPORT_SYMBOL(superio_func_add)
+EXPORT_SYMBOL(superio_func_add);
 
 static int superio_reg_read(void *ctx, unsigned int reg, unsigned int *val)
 {
@@ -95,4 +95,4 @@ void superio_chip_add(struct superio_chip *siochip)
 		pr_warn("registering %s regmap cdev failed: %s\n",
 			chipname, strerror(-ret));
 }
-EXPORT_SYMBOL(superio_chip_add)
+EXPORT_SYMBOL(superio_chip_add);
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 12/39] ARM: psci: declare locally used functions as static

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/cpu/psci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/cpu/psci.c b/arch/arm/cpu/psci.c
index 22ce1dfd0e84..c19994ae9cee 100644
--- a/arch/arm/cpu/psci.c
+++ b/arch/arm/cpu/psci.c
@@ -234,7 +234,7 @@ device_initcall(armv7_psci_init);
 #include <getopt.h>
 #include "mmu.h"
 
-void second_entry(void)
+static void second_entry(void)
 {
 	struct arm_smccc_res res;
 
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 13/39] ARM: mxs: bcb: declare locally used functions as static

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-mxs/bcb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-mxs/bcb.c b/arch/arm/mach-mxs/bcb.c
index fce607f63493..860508bde7c5 100644
--- a/arch/arm/mach-mxs/bcb.c
+++ b/arch/arm/mach-mxs/bcb.c
@@ -314,7 +314,7 @@ static int write_fcb(struct mtd_info *mtd, void *buf, int block)
 	return ret;
 }
 
-int update_bcb(int argc, char *argv[])
+static int update_bcb(int argc, char *argv[])
 {
 	int ret;
 	int block;
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 14/39] usb: dwc3: depend on OFDEVICE

[Lucas Stach]

The DWC3 driver uses some functions which are only available when
Barebox is built with OFDEVICE support. Since there is no platform
without DT support suing DWC3 we can reasonably depend on this
config option.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/usb/dwc3/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 09da1213744d..9d7b868dbafa 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -1,6 +1,7 @@
 config USB_DWC3
 	tristate "DesignWare USB3 DRD Core Support"
 	depends on USB && HAS_DMA
+	depends on OFDEVICE
 	select USB_XHCI
 	help
 	  Say Y or M here if your system has a Dual Role SuperSpeed
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 15/39] mtd: nand: don't call BBT functions if BBT support isn't built

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/mtd/nand/nand_base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 6b7d01919c59..00f0f7588434 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -407,7 +407,7 @@ static int nand_block_markbad_lowlevel(struct mtd_info *mtd, loff_t ofs)
 	}
 
 	/* Mark block bad in BBT */
-	if (chip->bbt) {
+	if (IS_ENABLED(CONFIG_NAND_BBT) && chip->bbt) {
 		res = nand_markbad_bbt(mtd, ofs);
 		if (!ret)
 			ret = res;
@@ -458,7 +458,7 @@ static int nand_block_markgood_lowlevel(struct mtd_info *mtd, loff_t ofs)
 	}
 
 	/* Mark block good in BBT */
-	if (chip->bbt) {
+	if (IS_ENABLED(CONFIG_NAND_BBT) && chip->bbt) {
 		ret = nand_markgood_bbt(mtd, ofs);
 		if (ret)
 			return ret;
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 16/39] mfd: da9063: don't try to register gpiochip when GPIOLIB isn't built

[Lucas Stach]

Fixes: feee4b638048 (gpio: add DA9062 MFD gpio support)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/mfd/da9063.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/mfd/da9063.c b/drivers/mfd/da9063.c
index e1343bac7618..967ca9ac51e4 100644
--- a/drivers/mfd/da9063.c
+++ b/drivers/mfd/da9063.c
@@ -402,13 +402,15 @@ static int da9063_probe(struct device_d *dev)
 
 	restart_handler_register(&priv->restart);
 
-	priv->gpio.base = -1;
-	priv->gpio.ngpio = 5;
-	priv->gpio.ops  = &da9063_gpio_ops;
-	priv->gpio.dev = dev;
-	ret = gpiochip_add(&priv->gpio);
-	if (ret)
-		goto on_error;
+	if (IS_ENABLED(CONFIG_GPIOLIB)) {
+		priv->gpio.base = -1;
+		priv->gpio.ngpio = 5;
+		priv->gpio.ops  = &da9063_gpio_ops;
+		priv->gpio.dev = dev;
+		ret = gpiochip_add(&priv->gpio);
+		if (ret)
+			goto on_error;
+	}
 
 	if (IS_ENABLED(CONFIG_OFDEVICE) && dev->device_node)
 		return of_platform_populate(dev->device_node, NULL, dev);
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 17/39] mci: MCI_IMX_ESDHC_PBL has no dependency on MCI

[Lucas Stach]

While it is located in the MCI deirectory, it has no direct dependency
on the MCI core, so it should not be under the MCI condition in Kconfig.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/Makefile    | 2 +-
 drivers/mci/Kconfig | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/Makefile b/drivers/Makefile
index 5a52225ee07e..b0d3a3f2006d 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -9,7 +9,7 @@ obj-y	+= usb/
 obj-$(CONFIG_DISK) += ata/
 obj-$(CONFIG_SPI) += spi/
 obj-$(CONFIG_I2C) += i2c/
-obj-$(CONFIG_MCI) += mci/
+obj-y += mci/
 obj-$(CONFIG_VIDEO) += video/
 obj-y	+= clk/
 obj-y	+= clocksource/
diff --git a/drivers/mci/Kconfig b/drivers/mci/Kconfig
index 4a71a4609763..33b700d7a629 100644
--- a/drivers/mci/Kconfig
+++ b/drivers/mci/Kconfig
@@ -97,9 +97,6 @@ config MCI_IMX_ESDHC_PIO
 	help
 	  mostly useful for debugging. Normally you should use DMA.
 
-config MCI_IMX_ESDHC_PBL
-	bool
-
 config MCI_OMAP_HSMMC
 	bool "OMAP HSMMC"
 	depends on ARCH_OMAP4 || ARCH_OMAP3 || ARCH_AM33XX
@@ -163,3 +160,6 @@ config MCI_STM32_SDMMC2
 	  say Y or M here.
 
 endif
+
+config MCI_IMX_ESDHC_PBL
+	bool
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 18/39] i2c: always walk down into i2c/busses Makefile

[Lucas Stach]

Otherwise CONFIG_I2C_IMX_EARLY won't be built if !CONFIG_I2C even
though it has no direct dependency on the i2c core.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/Makefile     | 2 +-
 drivers/i2c/Makefile | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/Makefile b/drivers/Makefile
index b0d3a3f2006d..08a17ff459d3 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -8,7 +8,7 @@ obj-y	+= mtd/
 obj-y	+= usb/
 obj-$(CONFIG_DISK) += ata/
 obj-$(CONFIG_SPI) += spi/
-obj-$(CONFIG_I2C) += i2c/
+obj-y += i2c/
 obj-y += mci/
 obj-$(CONFIG_VIDEO) += video/
 obj-y	+= clk/
diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
index c93653414eb6..b887e7557373 100644
--- a/drivers/i2c/Makefile
+++ b/drivers/i2c/Makefile
@@ -1,2 +1,3 @@
-obj-$(CONFIG_I2C) += i2c.o i2c-smbus.o busses/ algos/ muxes/
+obj-y += busses/
+obj-$(CONFIG_I2C) += i2c.o i2c-smbus.o algos/ muxes/
 obj-$(CONFIG_I2C_MUX) += i2c-mux.o
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 19/39] usb: usb251xb: depend on OFDEVICE

[Lucas Stach]

The usb2551x driver gets all its configuration info from the DT, so
there is no point in allowing this driver to be build when probing
from DT isn't enabled.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/usb/misc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
index 7d6c9da59462..270606f50bb8 100644
--- a/drivers/usb/misc/Kconfig
+++ b/drivers/usb/misc/Kconfig
@@ -6,6 +6,7 @@ comment "USB Miscellaneous drivers"
 config USB_HUB_USB251XB
 	bool "USB251XB Hub Controller Configuration Driver"
 	depends on I2C
+	depends on OFDEVICE
 	select NLS
 	help
 	  This option enables support for configuration via SMBus of the
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 20/39] pstore: don't try to grab non-existent logbuf

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 fs/pstore/platform.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 0a6fa38edca9..f4b77226d906 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -73,6 +73,9 @@ static void pstore_console_capture_log(void)
 	uint64_t id;
 	struct log_entry *log, *tmp;
 
+	if (IS_ENABLED(CONFIG_CONSOLE_NONE))
+		return;
+
 	list_for_each_entry_safe(log, tmp, &barebox_logbuf, list) {
 		psinfo->write_buf(PSTORE_TYPE_CONSOLE, 0, &id, 0,
 				  log->msg, 0, strlen(log->msg), psinfo);
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 21/39] firmware: zynqmp-fpga: fix comparison between pointer and integer

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/firmware/zynqmp-fpga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/zynqmp-fpga.c b/drivers/firmware/zynqmp-fpga.c
index 887865883ad2..1728e2a9545f 100644
--- a/drivers/firmware/zynqmp-fpga.c
+++ b/drivers/firmware/zynqmp-fpga.c
@@ -136,7 +136,7 @@ static int is_bin_header_valid(const u32 *bin_header, size_t size,
 		return 0;
 
 	for (i = 0; i < ARRAY_SIZE(bin_format); i++)
-		if (bin_header != (byte_order == XILINX_BYTE_ORDER_BIT) ?
+		if (bin_header[i] != (byte_order == XILINX_BYTE_ORDER_BIT) ?
 				  bin_format[i] : __swab32(bin_format[i]))
 			return 0;
 
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 22/39] pstore: ramoops: use correct format specifier for size_t variables

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 fs/pstore/ram.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index b96857969269..958f46b0ead0 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -623,10 +623,10 @@ static int ramoops_probe(struct device_d *dev)
 
 	if (!IS_ENABLED(CONFIG_OFTREE)) {
 		scnprintf(kernelargs, sizeof(kernelargs),
-			  "ramoops.record_size=0x%x "
-			  "ramoops.console_size=0x%x "
-			  "ramoops.ftrace_size=0x%x "
-			  "ramoops.pmsg_size=0x%x "
+			  "ramoops.record_size=0x%zx "
+			  "ramoops.console_size=0x%zx "
+			  "ramoops.ftrace_size=0x%zx "
+			  "ramoops.pmsg_size=0x%zx "
 			  "ramoops.mem_address=0x%llx "
 			  "ramoops.mem_size=0x%lx "
 			  "ramoops.ecc=%d",
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 23/39] clocksource: ARMv8 timer can only be built on ARMv8

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 43c5bfc9736a..44a6cef6fbae 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -73,7 +73,7 @@ config CLOCKSOURCE_ATMEL_PIT
 config CLOCKSOURCE_ARMV8_TIMER
 	bool
 	default y
-	depends on ARM && (CPU_64v8 || CPU_V7)
+	depends on ARM && CPU_V8
 
 config CLOCKSOURCE_ARM_GLOBAL_TIMER
 	bool
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 24/39] input: select POLLER

[Lucas Stach]

CONFIG_INPUT needs CONFIG_POLLER, so everything that selects INPUT
needs to also select POLLER.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/input/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
index be061683fb0a..e40032d91b2f 100644
--- a/drivers/input/Kconfig
+++ b/drivers/input/Kconfig
@@ -66,6 +66,7 @@ config KEYBOARD_USB
 
 config INPUT_SPECIALKEYS
 	bool "Special keys handler"
+	select POLLER
 	select INPUT
 	help
 	  Say Y here to handle key events like KEY_RESTART and KEY_POWER.
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 25/39] ARM: layerscape: add missing selects for TQMLS1046A

[Lucas Stach]

Make sure that all the lowlevel components are selected when only
this board is built.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-layerscape/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-layerscape/Kconfig b/arch/arm/mach-layerscape/Kconfig
index 139c63f66d39..c15d5873a55e 100644
--- a/arch/arm/mach-layerscape/Kconfig
+++ b/arch/arm/mach-layerscape/Kconfig
@@ -30,5 +30,8 @@ config MACH_LS1046ARDB
 config MACH_TQMLS1046A
 	bool "TQ TQMLS1046A Board"
 	select ARCH_LS1046
+	select MCI_IMX_ESDHC_PBL
+	select DDR_FSL
+	select DDR_FSL_DDR4
 
 endif
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 26/39] ARM: PBL break is not available on ARMv4

[Lucas Stach]

ARMv4 does not support the bkpt mnemonic. Rather than trying to work
around this, just disable this feature for ARMv4. On Tegra the PBL
runs on the ARM720T co-processor, so we also need to disable the option
for this SoC architecture.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 common/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/Kconfig b/common/Kconfig
index d397d8bc4d4d..60237d305676 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -1309,7 +1309,7 @@ config DEBUG_INITCALLS
 
 config PBL_BREAK
 	bool "Execute software break on pbl start"
-	depends on ARM
+	depends on ARM && (!CPU_32v4T && !ARCH_TEGRA)
 	help
 	  If this enabled, barebox will be compiled with BKPT instruction
 	  on early pbl init. This option should be used only with JTAG debugger!
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 27/39] ARM: ARM_SMCCC is only available on >= ARMv7

[Lucas Stach]

So anything selecting this option must depend on those CPU
architectures.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 9589a6a511e4..98abc2b97f72 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -433,6 +433,7 @@ config ARM_SMCCC
 	  This option enables barebox to invoke ARM secure monitor calls.
 
 config ARM_SECURE_MONITOR
+	depends on CPU_32v7 || CPU_64v8
 	select ARM_SMCCC
 	bool
 	help
@@ -452,6 +453,7 @@ config ARM_PSCI
 
 config ARM_PSCI_CLIENT
 	bool "Enable barebox PSCI client support"
+	depends on CPU_32v7 || CPU_64v8
 	select ARM_SMCCC
 	select ARM_PSCI_OF
 	help
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 28/39] ARM: layerscape: select OFTREE and OFDEVICE

[Lucas Stach]

The Layerscape architectures probes exclusively from DT, so
make sure the correct config options are enabled.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 98abc2b97f72..780a4707a299 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -106,6 +106,8 @@ config ARCH_LAYERSCAPE
 	select COMMON_CLK
 	select CLKDEV_LOOKUP
 	select COMMON_CLK_OF_PROVIDER
+	select OFTREE
+	select OFDEVICE
 
 config ARCH_MVEBU
 	bool "Marvell EBU platforms"
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 29/39] usb: dwc3: dual role mode needs gadget support

[Lucas Stach]

Obviously the mode where both host and gadget mode are available
also needs to depend on the Barebox gadget support.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/usb/dwc3/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 9d7b868dbafa..1b11f391fa8d 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -30,6 +30,7 @@ config USB_DWC3_GADGET
 
 config USB_DWC3_DUAL_ROLE
 	bool "Dual Role mode"
+	depends on USB_GADGET
 	help
 	  This is the default mode of working of DWC3 controller where
 	  both host and gadget features are enabled.
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 30/39] pinctrl: at91pio4: move to correct location in Kconfig

[Lucas Stach]

The driver also depends on PINCTRL, so we should only allow it to
be enabled if this option is selected. We can also drop the OFDEVICE
dependency then, as this is required for PINCTRL.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-at91/Kconfig |  1 +
 drivers/pinctrl/Kconfig    | 19 +++++++++----------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 5ad1f62c8d67..5267102bf94e 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -65,6 +65,7 @@ config SOC_SAMA5D2
 	select HAVE_AT91_UTMI
 	select HAVE_AT91_USB_CLK
 	select HAVE_AT91_GENERATED_CLK
+	select PINCTRL
 	select PINCTRL_AT91PIO4
 	select HAS_MACB
 	select HAVE_MACH_ARM_HEAD
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 95c6708f4a98..bddb1d780b94 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -17,16 +17,6 @@ config PINCTRL_AT91
 	help
 	    The pinmux controller found on AT91 SoCs.
 
-config PINCTRL_AT91PIO4
-        bool "AT91 PIO4 pinctrl driver"
-        depends on OFDEVICE
-        depends on ARCH_AT91
-        select GPIOLIB
-        select OF_GPIO
-        help
-          Say Y here to enable the at91 pinctrl/gpio driver for Atmel PIO4
-          controller available on sama5d2 SoC.
-
 config PINCTRL_BCM283X
 	bool "GPIO and pinmux support for BCM283X"
 	depends on ARCH_BCM283X
@@ -55,6 +45,15 @@ comment "OFDEVICE is not enabled."
 comment "Without device tree support PINCTRL won't do anything"
 endif
 
+config PINCTRL_AT91PIO4
+	bool "AT91 PIO4 pinctrl driver"
+	depends on ARCH_AT91
+	select GPIOLIB
+	select OF_GPIO
+	help
+	  Say Y here to enable the at91 pinctrl/gpio driver for Atmel PIO4
+	  controller available on sama5d2 SoC.
+
 config PINCTRL_MXS
 	bool "MXS pinctrl"
 	depends on ARCH_MXS
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 31/39] ARM: layerscape: ppa: use sync_for_execution instead of a manual cache flush

[Lucas Stach]

The copied code is then jumped to, so we need to sync the caches for
execution instead of just flushing the data caches.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-layerscape/ppa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-layerscape/ppa.c b/arch/arm/mach-layerscape/ppa.c
index 607045102071..987cb6587608 100644
--- a/arch/arm/mach-layerscape/ppa.c
+++ b/arch/arm/mach-layerscape/ppa.c
@@ -14,9 +14,9 @@
 #include <image-fit.h>
 #include <asm/psci.h>
 #include <mach/layerscape.h>
+#include <asm/cache.h>
 
 int ppa_entry(const void *, u32 *, u32 *);
-void dma_flush_range(void *ptr, size_t size);
 
 static int of_psci_do_fixup(struct device_node *root, void *unused)
 {
@@ -73,7 +73,7 @@ static int ppa_init(void *ppa, size_t ppa_size, void *sec_firmware_addr)
 
 	/* Copy the secure firmware to secure memory */
 	memcpy(sec_firmware_addr, buf, firmware_size);
-	dma_flush_range(sec_firmware_addr, ppa_size);
+	sync_caches_for_execution();
 
 	ret = ppa_entry(sec_firmware_addr, boot_loc_ptr_l, boot_loc_ptr_h);
 	if (ret) {
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 32/39] ubootvarfs: depend on OFTREE

[Lucas Stach]

This driver can only be probed from DT and needs some OFTREE only
functions to work correctly. Depend on the config option to make
sure they are available.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/misc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 0f736f8bded3..8abbf69b3a83 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -25,6 +25,7 @@ config DEV_MEM
 
 config UBOOTVAR
 	bool "U-Boot environment storage"
+	depends on OFTREE
 	help
 	  This driver exposes U-Boot environment variable storage as a
 	  single mmap-able device, hiding various low-level details
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 33/39] ARM: davinci: virt2real: select OFTREE and OFDEVICE

[Lucas Stach]

The board probes from DT, so there is no point in allowing a
configuration without OF support.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-davinci/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 66d3d7a5f7ab..c6d4fce603ae 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -9,6 +9,8 @@ choice
 
 config MACH_VIRT2REAL
 	bool "Virt2Real"
+	select OFTREE
+	select OFDEVICE
 
 endchoice
 
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 34/39] ARM: omap: pfc200: NAND support requires CONFIG_OMAP_GPMC

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/boards/wago-pfc-am35xx/board-mlo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boards/wago-pfc-am35xx/board-mlo.c b/arch/arm/boards/wago-pfc-am35xx/board-mlo.c
index 7925c71a4b53..c940565b4af4 100644
--- a/arch/arm/boards/wago-pfc-am35xx/board-mlo.c
+++ b/arch/arm/boards/wago-pfc-am35xx/board-mlo.c
@@ -48,7 +48,7 @@ static int pfc200_mem_init(void)
 }
 mem_initcall(pfc200_mem_init);
 
-static struct gpmc_nand_platform_data nand_plat = {
+__maybe_unused static struct gpmc_nand_platform_data nand_plat = {
 	.cs = 0,
 	.device_width = 8,
 	.ecc_mode = OMAP_ECC_BCH8_CODE_HW_ROMCODE,
@@ -62,8 +62,8 @@ static int pfc200_init_devices(void)
 	 * WP is made high and WAIT1 active Low
 	 */
 	gpmc_generic_init(0x10);
-#endif
 	omap_add_gpmc_nand_device(&nand_plat);
+#endif
 	omap_set_barebox_part(&pfc200_mlo_part);
 
 	omap3_add_mmc1(NULL);
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 35/39] net: designware-eqos: depend on COMMON_CLK

[Lucas Stach]

The clk_bulk_* functions are only available with common clock.
Also OFTREE should not be selected, but is a dependency.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/net/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 62e522a302ad..5823320b03f1 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -90,8 +90,9 @@ endif
 config DRIVER_NET_DESIGNWARE_EQOS
 	bool "Designware Designware Ethernet QoS support"
 	depends on HAS_DMA
+	depends on COMMON_CLK
+	depends on OFTREE
 	select PHYLIB
-	select OFTREE
 	help
 	  This option enables support for the Synopsys
 	  Designware Ethernet Quality-of-Service (GMAC4).
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 36/39] ARM: mvebu: correct DTB rule for MARVELL_ARMADA_XP_DB

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/dts/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 294a0bfa5525..9566e975551e 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -33,7 +33,8 @@ lwl-dtb-$(CONFIG_MACH_GW_VENTANA) += imx6q-gw54xx.dtb.o
 lwl-dtb-$(CONFIG_MACH_KONTRON_SAMX6I) += imx6q-samx6i.dtb.o \
 					imx6dl-samx6i.dtb.o
 lwl-dtb-$(CONFIG_MACH_LENOVO_IX4_300D) += armada-xp-lenovo-ix4-300d-bb.dtb.o
-lwl-dtb-$(CONFIG_MACH_MARVELL_ARMADA_XP_GP) += armada-xp-gp-bb.dtb.o armada-xp-db-bb.dtb.o
+lwl-dtb-$(CONFIG_MACH_MARVELL_ARMADA_XP_GP) += armada-xp-gp-bb.dtb.o
+lwl-dtb-$(CONFIG_MACH_MARVELL_ARMADA_XP_DB) += armada-xp-db-bb.dtb.o
 lwl-dtb-$(CONFIG_MACH_MB7707) += module-mb7707.dtb.o
 lwl-dtb-$(CONFIG_MACH_MX28EVK) += imx28-evk.dtb.o
 lwl-dtb-$(CONFIG_MACH_NETGEAR_RN104) += armada-370-rn104-bb.dtb.o
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 37/39] nvme: correct symbol export name for nvme_submit_sync_cmd

[Lucas Stach]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index d2c2b6f30630..257679fae834 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -20,7 +20,7 @@ int nvme_submit_sync_cmd(struct nvme_ctrl *ctrl,
 	return __nvme_submit_sync_cmd(ctrl, cmd, NULL, buffer, bufflen, 0,
 				      NVME_QID_ADMIN);
 }
-EXPORT_SYMBOL_GPL(nvme_sec_submit);
+EXPORT_SYMBOL_GPL(nvme_submit_sync_cmd);
 
 static int nvme_identify_ctrl(struct nvme_ctrl *dev, struct nvme_id_ctrl **id)
 {
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 38/39] pinctrl: tegra: mark drvdata as maybe unused

[Lucas Stach]

If the driver is only built for one of the two supported SoCs we end
up with some unused structures.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/pinctrl/pinctrl-tegra30.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-tegra30.c b/drivers/pinctrl/pinctrl-tegra30.c
index ffb04eebbffd..278ea8c4a0b3 100644
--- a/drivers/pinctrl/pinctrl-tegra30.c
+++ b/drivers/pinctrl/pinctrl-tegra30.c
@@ -388,7 +388,7 @@ static const struct tegra_drive_pingroup tegra30_drive_groups[] = {
 	DRV_PG(vi1,   0x8c8, -1, -1, -1,  14,  5,  19,  5,  24,  4,  28,  4),
 };
 
-static const struct pinctrl_tegra30_drvdata tegra30_drvdata = {
+__maybe_unused static const struct pinctrl_tegra30_drvdata tegra30_drvdata = {
 	.pingrps = tegra30_pin_groups,
 	.num_pingrps = ARRAY_SIZE(tegra30_pin_groups),
 	.drvgrps = tegra30_drive_groups,
@@ -632,7 +632,7 @@ static const struct tegra_drive_pingroup tegra124_drive_groups[] = {
 	DRV_PG(ao4,   0x9c8,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2),
 };
 
-static const struct pinctrl_tegra30_drvdata tegra124_drvdata = {
+__maybe_unused static const struct pinctrl_tegra30_drvdata tegra124_drvdata = {
 	.pingrps = tegra124_pin_groups,
 	.num_pingrps = ARRAY_SIZE(tegra124_pin_groups),
 	.drvgrps = tegra124_drive_groups,
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 39/39] pinctrl: at91pio4 depends on OFDEVICE

[Lucas Stach]

Some of the selected options require OFDEVICE to be enabled. As the driver
is only used of DT probed systems it's okay to depend on OFDEVICE.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index bddb1d780b94..fd75ea6a4f43 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -48,6 +48,7 @@ endif
 config PINCTRL_AT91PIO4
 	bool "AT91 PIO4 pinctrl driver"
 	depends on ARCH_AT91
+	depends on OFDEVICE
 	select GPIOLIB
 	select OF_GPIO
 	help
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 00/39] randcfg build fixes

[Sascha Hauer]

On Fri, Nov 29, 2019 at 04:14:26PM +0100, Lucas Stach wrote:
> Hi,
> 
> this series is a set of fixes that have accumulated in the randcfg
> build tests. All of them survived serveral rounds of build testing
> without causing any new issues. Not all of them fix build breakages,
> a significant number is just fixing compiler warnings that showed
> up in the build jobs.

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 01/39] ARM: imx: add image type choice

[Sascha Hauer]

On Fri, Nov 29, 2019 at 04:14:27PM +0100, Lucas Stach wrote:
> ARM32 and ARM64 boards can not be built into the same image. Make this
> clear by adding a choice for the different image types. While at it
> add a single board option.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm/mach-imx/Kconfig | 56 +++++++++++++++++++++++++--------------
>  1 file changed, 36 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 6e98e95dbb00..f39d58ecefb2 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -199,10 +199,22 @@ config ARCH_VF610
>  	select IMX_OCOTP	# Needed for clock adjustement
>  	select CLOCKSOURCE_ARM_GLOBAL_TIMER
>  
> +choice
> +	prompt "Build type"
> +
>  config IMX_MULTI_BOARDS
> -	bool "Allow multiple boards to be selected"
> +	bool "Allow multiple ARM32 boards to be selected"
> +	select HAVE_PBL_MULTI_IMAGES
> +
> +config IMX_MULTI_BOARDS64
> +	bool "Allow multiple ARM64 boards to be selected"
>  	select HAVE_PBL_MULTI_IMAGES
>  
> +config IMX_SINGLE_BOARD
> +	bool "Select single board (legacy)"
> +
> +endchoice

This breaks several defconfigs that now have the wrong default for this
choice:

cupid_defconfig
eukrea_cpuimx25_defconfig
eukrea_cpuimx27_defconfig
eukrea_cpuimx35_defconfig
eukrea_cpuimx51_defconfig
freescale-mx21-ads_defconfig
freescale-mx25-3ds_defconfig
freescale-mx27-ads_defconfig
freescale-mx35-3ds_defconfig
freescale-mx53-smd_defconfig
imx_v8_defconfig
kindle3_defconfig
neso_defconfig
phytec-phycore-imx31_defconfig
phytec-phycore-imx35_defconfig
tx51stk5_defconfig

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 01/39] ARM: imx: add image type choice

[Lucas Stach]

On Mo, 2019-12-02 at 11:07 +0100, Sascha Hauer wrote:
> On Fri, Nov 29, 2019 at 04:14:27PM +0100, Lucas Stach wrote:
> > ARM32 and ARM64 boards can not be built into the same image. Make this
> > clear by adding a choice for the different image types. While at it
> > add a single board option.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  arch/arm/mach-imx/Kconfig | 56 +++++++++++++++++++++++++--------------
> >  1 file changed, 36 insertions(+), 20 deletions(-)
> > 
> > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > index 6e98e95dbb00..f39d58ecefb2 100644
> > --- a/arch/arm/mach-imx/Kconfig
> > +++ b/arch/arm/mach-imx/Kconfig
> > @@ -199,10 +199,22 @@ config ARCH_VF610
> >  	select IMX_OCOTP	# Needed for clock adjustement
> >  	select CLOCKSOURCE_ARM_GLOBAL_TIMER
> >  
> > +choice
> > +	prompt "Build type"
> > +
> >  config IMX_MULTI_BOARDS
> > -	bool "Allow multiple boards to be selected"
> > +	bool "Allow multiple ARM32 boards to be selected"
> > +	select HAVE_PBL_MULTI_IMAGES
> > +
> > +config IMX_MULTI_BOARDS64
> > +	bool "Allow multiple ARM64 boards to be selected"
> >  	select HAVE_PBL_MULTI_IMAGES
> >  
> > +config IMX_SINGLE_BOARD
> > +	bool "Select single board (legacy)"
> > +
> > +endchoice
> 
> This breaks several defconfigs that now have the wrong default for this
> choice:
> 
> cupid_defconfig
> eukrea_cpuimx25_defconfig
> eukrea_cpuimx27_defconfig
> eukrea_cpuimx35_defconfig
> eukrea_cpuimx51_defconfig
> freescale-mx21-ads_defconfig
> freescale-mx25-3ds_defconfig
> freescale-mx27-ads_defconfig
> freescale-mx35-3ds_defconfig
> freescale-mx53-smd_defconfig
> imx_v8_defconfig
> kindle3_defconfig
> neso_defconfig
> phytec-phycore-imx31_defconfig
> phytec-phycore-imx35_defconfig
> tx51stk5_defconfig

Uh, sorry about this. Somehow I already had a feeling that his patch
might mess something up...

Can you remove this single patch from the series? I'll send an updated
patch after some soak time in the randconfig builder.

Regards,
Lucas


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 01/39] ARM: imx: add image type choice

[Sascha Hauer]

On Mon, Dec 02, 2019 at 11:51:08AM +0100, Lucas Stach wrote:
> Uh, sorry about this. Somehow I already had a feeling that his patch
> might mess something up...
> 
> Can you remove this single patch from the series? I'll send an updated
> patch after some soak time in the randconfig builder.

Did that. The rest of the series doesn't introduce any compile test
regressions.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox