From: Roland Hieber <rhi@pengutronix.de>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] HABv4: remove useless error message
Date: Mon, 2 Dec 2019 14:07:36 +0100 [thread overview]
Message-ID: <20191202130736.xgs53nadr5uvokea@pengutronix.de> (raw)
In-Reply-To: <20191202102449.23535-1-jbe@pengutronix.de>
On Mon, Dec 02, 2019 at 11:24:48AM +0100, Juergen Borleis wrote:
> This change removes the stupid error message at the end of the generated
I think there was some reason behind that code, so it is probably not
stupid, and you've run into an edge case that never happened before (at
least I've never seen this on any of my boards when using HABv4).
The code goes back until the first incarnaction of HABv4 in commit
29abc10d44c2 - Marc, do you still know more details why it was done this
way?
- Roland
> list of HAB events. It seems it was added for debugging/development
> purposes, because it always reports an error like
>
> "HABv4: ERROR: Recompile with larger event data buffer (at least 20 bytes)"
>
> which is completely nonsense, since the we already provide a buffer with
> 256 bytes...
>
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> ---
> drivers/hab/habv4.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/hab/habv4.c b/drivers/hab/habv4.c
> index e3c1de1a4d..f1f45648f5 100644
> --- a/drivers/hab/habv4.c
> +++ b/drivers/hab/habv4.c
> @@ -555,12 +555,6 @@ static int habv4_get_status(const struct habv4_rvt *rvt)
> index++;
> }
>
> - /* Check reason for stopping */
> - len = sizeof(data);
> - index = 0;
> - if (rvt->report_event(HAB_STATUS_ANY, index, NULL, &len) == HAB_STATUS_SUCCESS)
> - pr_err("ERROR: Recompile with larger event data buffer (at least %d bytes)\n\n", len);
> -
> return -EPERM;
> }
>
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-12-02 13:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 10:24 Juergen Borleis
2019-12-02 10:24 ` [PATCH 2/2] HABv4: fix ROM code API usage Juergen Borleis
2019-12-02 13:07 ` Roland Hieber [this message]
2019-12-02 13:24 ` [PATCH 1/2] HABv4: remove useless error message Marc Kleine-Budde
2019-12-02 13:33 ` Roland Hieber
2019-12-02 13:38 ` Marc Kleine-Budde
2019-12-02 14:30 ` Juergen Borleis
2019-12-03 14:04 ` Marc Kleine-Budde
2019-12-03 14:36 ` Sascha Hauer
2019-12-03 14:47 ` Marc Kleine-Budde
2019-12-03 14:51 ` Juergen Borleis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202130736.xgs53nadr5uvokea@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox