Re: [PATCH 1/2] HABv4: remove useless error message

[Roland Hieber <rhi@pengutronix.de>]

On Mon, Dec 02, 2019 at 02:24:54PM +0100, Marc Kleine-Budde wrote:
> On 12/2/19 2:07 PM, Roland Hieber wrote:
> > On Mon, Dec 02, 2019 at 11:24:48AM +0100, Juergen Borleis wrote:
> >> This change removes the stupid error message at the end of the generated
> > 
> > I think there was some reason behind that code, so it is probably not
> > stupid, and you've run into an edge case that never happened before (at
> > least I've never seen this on any of my boards when using HABv4).
> 
> The last time, I've seen this messages was before implementing:
> 
> 81e2b508e785 i.MX habv4: habv4_get_status(): display warning events, too
> 
> So Roland is probably right, you've hit a corner case, that's not
> correctly handled.
> 
> > The code goes back until the first incarnaction of HABv4 in commit
> > 29abc10d44c2 - Marc, do you still know more details why it was done this
> > way?
> 
> This was part of the patches I picked up from fsl, see commit message
> for more details:
> 
> 29abc10d44c2 habv4: add High Assurance Boot v4
> 
> Albeit giving an incorrect error message, it showed that there were
> warnings events on the new mx6 silicon revisions that were not handled
> before 81e2b508e785.

So that means the code is no longer needed now, and Jürgens patch does
the right thing?

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox