[PATCH] led: pca955x: remove ineffectual assignment

[PATCH] led: pca955x: remove ineffectual assignment

[Ahmad Fatoum]

the .num member of struct led is a 'private' member populated by
led_register. Populating it has no effect because it's always
overwritten. Remove the assignment.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/led/led-pca955x.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/led/led-pca955x.c b/drivers/led/led-pca955x.c
index 9c4f7967fb28..27fefce8d524 100644
--- a/drivers/led/led-pca955x.c
+++ b/drivers/led/led-pca955x.c
@@ -316,7 +316,6 @@ led_pca955x_pdata_of_init(struct device_node *np, struct pca955x *pca955x)
 
 		pca955x_led->led_cdev.name = pca955x_led->name;
 		pca955x_led->led_cdev.set = pca955x_led_set;
-		pca955x_led->led_cdev.num = pca955x_led->led_num;
 		pca955x_led->led_cdev.max_value = 255;
 
 		err = led_register(&pca955x_led->led_cdev);
-- 
2.24.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] led: pca955x: remove ineffectual assignment

[Sascha Hauer]

On Thu, Dec 12, 2019 at 08:24:57PM +0100, Ahmad Fatoum wrote:
> the .num member of struct led is a 'private' member populated by
> led_register. Populating it has no effect because it's always
> overwritten. Remove the assignment.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/led/led-pca955x.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox