From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>, Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fs: remove unused struct fs_device_d::parent_device
Date: Tue, 14 Sep 2021 11:02:23 +0200 [thread overview]
Message-ID: <201c33e8-a3ff-406d-7647-28bf4cf6d6a4@pengutronix.de> (raw)
In-Reply-To: <20210914085553.ggnadiwz3ldjvr2o@pengutronix.de>
On 14.09.21 10:55, Roland Hieber wrote:
> On Mon, Sep 13, 2021 at 10:30:19AM +0200, Ahmad Fatoum wrote:
>> The parent_device member is unused anywhere, so drop it.
>
> s/is/isn't/?
is unused == isn't used..?
>
>>
>> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
>> ---
>> fs/fs.c | 1 -
>> include/fs.h | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/fs/fs.c b/fs/fs.c
>> index b6431227d60c..e6fd57b8ac97 100644
>> --- a/fs/fs.c
>> +++ b/fs/fs.c
>> @@ -813,7 +813,6 @@ int fsdev_open_cdev(struct fs_device_d *fsdev)
>> }
>>
>> fsdev->dev.parent = fsdev->cdev->dev;
>> - fsdev->parent_device = fsdev->cdev->dev;
>>
>> return 0;
>> }
>> diff --git a/include/fs.h b/include/fs.h
>> index 5811199c0161..cd5eb571e08e 100644
>> --- a/include/fs.h
>> +++ b/include/fs.h
>> @@ -101,7 +101,6 @@ struct fs_device_d {
>> struct cdev *cdev;
>> bool loop;
>> char *path;
>> - struct device_d *parent_device;
>> struct list_head list;
>> char *options;
>> char *linux_rootarg;
>> --
>> 2.33.0
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-09-14 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 8:30 Ahmad Fatoum
2021-09-14 8:55 ` Roland Hieber
2021-09-14 9:02 ` Ahmad Fatoum [this message]
2021-09-14 10:10 ` Roland Hieber
2021-10-04 10:44 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201c33e8-a3ff-406d-7647-28bf4cf6d6a4@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox