From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioOmy-0002FI-6Q for barebox@lists.infradead.org; Mon, 06 Jan 2020 09:35:21 +0000 Date: Mon, 6 Jan 2020 10:35:03 +0100 From: Sascha Hauer Message-ID: <20200106093503.v4kftjlk3p5u6ut2@pengutronix.de> References: <1576673837-71180-1-git-send-email-m.otto@phytec.de> <20191220152441.thp3kn2wfnw76xgl@pengutronix.de> <87imm8huub.fsf@grinn-global.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87imm8huub.fsf@grinn-global.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2] habv4: imx change signing area from full to the executed image To: Marcin =?iso-8859-15?Q?Niestr=F3j?= Cc: Maik Otto , barebox@lists.infradead.org On Sun, Dec 22, 2019 at 11:13:48PM +0100, Marcin Niestr=F3j wrote: > Hi Sasha, Maik, > = > Sascha Hauer writes: > = > > On Wed, Dec 18, 2019 at 01:57:17PM +0100, Maik Otto wrote: > >> the whole barebox with mbr and partition table were be signed by defau= lt. > >> change the signing to the executed image without signing the mbr, > >> partition table and header_gap by imx8mq > >> additional delete option full, from-dcdofs and skip-mbr > >> > >> Signed-off-by: Maik Otto > >> --- > >> Changes in v2: > >> - change subject from habv4: add the possibility to changing the s= igning > >> area from Kconfig to > >> - delete KConfig entries > >> - delete changes habv4-imx6-gencsf.h > >> - delete full, from-dcdofs and skip-mbr options > >> --- > >> scripts/imx/imx.c | 33 +++++++++------------------------ > >> 1 file changed, 9 insertions(+), 24 deletions(-) > > > > Applied, thanks. > > > > @Marcin, as you introduced the "from-dcdofs" and "full" options, are you > > happy with this patch? It removes the options, but should default to > > what you originally wanted to archieve, right? > = > I think that when adding separate skip-mbr and from-dcdofs I wanted to > protect (with skip-mbr) first bytes of generated image, which contain > barebox header (with its version?) from what I remember. I never used > that information from there, so I am quite okay with dropping skip-mbr > support in favor of only from-dcdofs. The version is not contained in the header. > = > However I wonder why offset_load_address is hardcoded to > 0x400. Shouldn't we leave from-dcdofs as is and simply dropping all > other options (full and skip-mbr)? Yes, this sounds better. Maik, can you change the patch accordingly? Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox