mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: qemu-virt64: convert to assembly entry
Date: Thu, 16 Jan 2020 09:28:43 +0100	[thread overview]
Message-ID: <20200116082843.q2fh7yiw22pv64ru@pengutronix.de> (raw)
In-Reply-To: <20200114201744.267746-1-dev@lynxeye.de>

On Tue, Jan 14, 2020 at 09:17:44PM +0100, Lucas Stach wrote:
> The C entry function isn't naked, so tries to push to the stack
> in the function prologue. This doesn't work on QEMU where there
> is no valid SP on entry. Convert the lowlevel entry to the
> assembly facilities provided for this case.
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
>  arch/arm/boards/qemu-virt64/Makefile        |  2 +-
>  arch/arm/boards/qemu-virt64/lowlevel.c      |  4 +++-
>  arch/arm/boards/qemu-virt64/lowlevel_init.S | 12 ++++++++++++
>  3 files changed, 16 insertions(+), 2 deletions(-)
>  create mode 100644 arch/arm/boards/qemu-virt64/lowlevel_init.S

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-01-16  8:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 20:17 Lucas Stach
2020-01-16  8:28 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116082843.q2fh7yiw22pv64ru@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=dev@lynxeye.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox