From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1is2oK-00072R-OW for barebox@lists.infradead.org; Thu, 16 Jan 2020 10:55:41 +0000 Date: Thu, 16 Jan 2020 11:55:34 +0100 From: Sascha Hauer Message-ID: <20200116105534.6wfpjkmrgeixaehy@pengutronix.de> References: <20200115102650.11739-1-cleger@kalray.eu> <20200115102650.11739-2-cleger@kalray.eu> <20200116092648.gkvfpjprffkutvej@pengutronix.de> <579667717.12546207.1579171771523.JavaMail.zimbra@kalray.eu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <579667717.12546207.1579171771523.JavaMail.zimbra@kalray.eu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/5] k1c: Initial Kalray Coolidge (k1c) architecture support To: =?iso-8859-15?Q?Cl=E9ment?= Leger Cc: Barebox List On Thu, Jan 16, 2020 at 11:49:31AM +0100, Cl=E9ment Leger wrote: > Hi Sasha > = > ----- On 16 Jan, 2020, at 10:26, Sascha Hauer s.hauer@pengutronix.de wrot= e: > = > > On Wed, Jan 15, 2020 at 11:26:46AM +0100, Clement Leger wrote: > >> +config MALLOC_BASE > >> + hex > >> + default 0x100000000 > >> + > >> +config MALLOC_SIZE > >> + hex > >> + default 0x800000 > >> + prompt "malloc area size" > >> +endmenu > > = > >> diff --git a/arch/k1c/lib/board.c b/arch/k1c/lib/board.c > >> new file mode 100644 > >> index 000000000..d17a32614 > >> --- /dev/null > >> +++ b/arch/k1c/lib/board.c > >> @@ -0,0 +1,20 @@ > >> +// SPDX-License-Identifier: GPL-2.0-only > >> +/* > >> + * Copyright (C) 2019 Kalray Inc. > >> + */ > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> + > >> +void __noreturn k1c_start_barebox(void) > >> +{ > >> + mem_malloc_init((void *)CONFIG_MALLOC_BASE, > >> + (void *)(CONFIG_MALLOC_BASE + MALLOC_SIZE - 1)); > > = > > You could extract valid memory from the device tree instead and pick > > some memory for malloc there. See of_find_mem() how this can be done. > = > I think we are going to bite our tail here since of_unflatten_dtb does > some xzalloc to unflatten the DTB so we need to initialize the malloc > allocator before accessing DTB. of_find_mem() doesn't use of_unflatten_dtb(), it uses libfdt to parse the device tree. Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox