From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itRsW-0005Mq-Q0 for barebox@lists.infradead.org; Mon, 20 Jan 2020 07:53:49 +0000 Date: Mon, 20 Jan 2020 08:53:40 +0100 From: Sascha Hauer Message-ID: <20200120075340.eanezlzfyb4asx75@pengutronix.de> References: <20200117181716.1775-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200117181716.1775-1-a.fatoum@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] net: designware: eqos: don't funnel all MDIO writes to register 0 To: Ahmad Fatoum Cc: barebox@lists.infradead.org On Fri, Jan 17, 2020 at 07:17:16PM +0100, Ahmad Fatoum wrote: > eqos_mdio_write ended up using the addr parameter instead of the > computed miiaddr variable, which would've factored in the reg parameter. > > This had the effect that all writes went to PHY register 0, which was > fine as long as there were only register 0 writes. As soon there are more > writes, e.g. because a PHY driver was enabled, register 0 became > clobbered and erratic behavior ensued. > Fix the typo and while at it rename the val parameter to a more > descriptive name. > > Fixes: a4f709bbb ("net: add Designware Ethernet QoS for STM32MP") > Signed-off-by: Ahmad Fatoum > --- > Could this be applied to master? Thanks. Did that. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox