From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christian Eggers <ceggers@arri.de>
Cc: barebox@lists.infradead.org, ceggers@gmx.de
Subject: Re: [PATCH 1/3] watchdog: Select CONFIG_PARAMETER
Date: Wed, 22 Jan 2020 09:21:15 +0100 [thread overview]
Message-ID: <20200122082115.tgwaf72ootkmkf5s@pengutronix.de> (raw)
In-Reply-To: <20200121114421.24401-1-ceggers@arri.de>
Hi Christian,
On Tue, Jan 21, 2020 at 12:44:19PM +0100, Christian Eggers wrote:
> Without CONFIG_PARAMETER, watchdog_register() will always fail.
>
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 45dd41a2a..34b7fea39 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -4,6 +4,7 @@ config WATCHDOG_IMX_RESET_SOURCE
>
> menuconfig WATCHDOG
> bool "Watchdog support"
> + select PARAMETER
I think this goes into the wrong direction. With CONFIG_PARAMETER
enabled we get support for adjusting device parameters from the shell.
In environments without shell support parameter support is not needed.
For example the watchdog C API doesn't need parameter support and is
still usable.
The static inline wrappers for dev_add_param_* should return NULL
instead of returning ERR_PTR(-ENOSYS).
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-01-22 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 11:44 Christian Eggers
2020-01-21 11:44 ` [PATCH 2/3] usb: otg: " Christian Eggers
2020-01-21 11:44 ` [PATCH 3/3] globalvar: " Christian Eggers
2020-01-22 8:21 ` Sascha Hauer [this message]
2020-01-22 9:39 ` [PATCH 1/3] watchdog: " Christian Eggers
2020-01-22 19:54 ` Sascha Hauer
2020-01-23 11:18 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122082115.tgwaf72ootkmkf5s@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ceggers@arri.de \
--cc=ceggers@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox