[PATCH] usb: udc: don't warn on unused gadget

[PATCH] usb: udc: don't warn on unused gadget

[Uwe Kleine-König]

Whenever a machine boots but didn't make use of the udc device
an error message is emitted. This is hardly useful, so drop the
message.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/usb/gadget/udc-core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
index 096f05ed48df..4d5a95c6cbee 100644
--- a/drivers/usb/gadget/udc-core.c
+++ b/drivers/usb/gadget/udc-core.c
@@ -280,8 +280,6 @@ void usb_del_gadget_udc(struct usb_gadget *gadget)
 		if (udc->gadget == gadget)
 			goto found;
 
-	dev_err(gadget->dev.parent, "gadget not registered.\n");
-
 	return;
 
 found:
-- 
2.24.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] usb: udc: don't warn on unused gadget

[Sascha Hauer]

On Fri, Jan 24, 2020 at 11:46:38AM +0100, Uwe Kleine-König wrote:
> Whenever a machine boots but didn't make use of the udc device
> an error message is emitted. This is hardly useful, so drop the
> message.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/usb/gadget/udc-core.c | 2 --
>  1 file changed, 2 deletions(-)

On which barebox version did you see the message? Since
28b38c1804d761257397f41ae2bbc071cd009935 it should be gone.

Sascha

> 
> diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
> index 096f05ed48df..4d5a95c6cbee 100644
> --- a/drivers/usb/gadget/udc-core.c
> +++ b/drivers/usb/gadget/udc-core.c
> @@ -280,8 +280,6 @@ void usb_del_gadget_udc(struct usb_gadget *gadget)
>  		if (udc->gadget == gadget)
>  			goto found;
>  
> -	dev_err(gadget->dev.parent, "gadget not registered.\n");
> -
>  	return;
>  
>  found:
> -- 
> 2.24.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] usb: udc: don't warn on unused gadget

[Uwe Kleine-König]

On Fri, Jan 24, 2020 at 01:09:50PM +0100, Sascha Hauer wrote:
> On Fri, Jan 24, 2020 at 11:46:38AM +0100, Uwe Kleine-König wrote:
> > Whenever a machine boots but didn't make use of the udc device
> > an error message is emitted. This is hardly useful, so drop the
> > message.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  drivers/usb/gadget/udc-core.c | 2 --
> >  1 file changed, 2 deletions(-)
> 
> On which barebox version did you see the message? Since
> 28b38c1804d761257397f41ae2bbc071cd009935 it should be gone.

For sure on 2018.05, just tested on 2019.07, there it is indeed gone.

So let's drop this patch.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox