From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jules Maselbas <jmaselbas@kalray.eu>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 1/7] usb: dwc2: Add host controller driver
Date: Tue, 28 Jan 2020 09:01:30 +0100 [thread overview]
Message-ID: <20200128080130.fcps4emjoudtixzx@pengutronix.de> (raw)
In-Reply-To: <20200127172312.pwkse4ggrmnv4smd@tellis.lin.mbt.kalray.eu>
On Mon, Jan 27, 2020 at 06:23:12PM +0100, Jules Maselbas wrote:
> Hi Sascha,
>
> On Fri, Jan 24, 2020 at 03:32:59PM +0100, Sascha Hauer wrote:
> > Hi Jules,
> >
> > I can confirm the driver works on the RaspberryPi with some adjustments,
> > see below. Some more comments inline.
> >
> > > +static int wait_for_chhltd(struct dwc2 *dwc2, u8 hc, uint32_t *sub, u8 *tgl)
> > > +{
> > > + int ret;
> > > + uint32_t hcint, hctsiz;
> > > +
> > > + ret = dwc2_wait_bit_set(dwc2, HCINT(hc), HCINTMSK_CHHLTD, 10000);
> > > + if (ret)
> > > + dwc2_err(dwc2, "%s: Timeout! Channel not halted\n", __func__);
> >
> > This is not an error, but a normal usecase. This should be:
> >
> > if (ret) {
> > uint32_t val = dwc2_readl(dwc2, HCCHAR(hc));
> > dwc2_writel(dwc2, val | HCCHAR_CHDIS, HCCHAR(hc));
> > dwc2_wait_bit_set(dwc2, HCINT(hc), HCINTMSK_CHHLTD, 10000);
> > return ret;
> > }
> Okay I will make this change, but should this return if the last call to
> wait_bit_set() is successful?
No. If the last call to wait_bit_set is successful it means that we
successfully stopped the ongoing transfer. The transfer itself still
timed out and we want to tell this to the caller.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-01-28 8:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 15:49 [PATCH v2 0/7] usb: dwc2 host driver Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 1/7] usb: dwc2: Add host controller driver Jules Maselbas
2020-01-24 14:32 ` Sascha Hauer
2020-01-27 17:23 ` Jules Maselbas
2020-01-28 8:01 ` Sascha Hauer [this message]
2020-01-22 15:49 ` [PATCH v2 2/7] usb: dwc2: host: Read dr_mode from device tree Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 3/7] usb: dwc2: host: Rework roothub interface Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 4/7] usb: dwc2: host: Handle dma mapping errors Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 5/7] usb: dwc2: host: Dynamic fifo size support from Linux Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 6/7] usb: dwc2: host: Fix toggle reset Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 7/7] usb: dwc2: host: Rewrite dwc2_hc_init Jules Maselbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128080130.fcps4emjoudtixzx@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox