From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christian Eggers <ceggers@arri.de>
Cc: barebox@lists.infradead.org, ceggers@gmx.de
Subject: Re: [SPAM:54%] Re: [PATCH] barebox_banner: switch to pr_notice
Date: Tue, 28 Jan 2020 10:59:29 +0100 [thread overview]
Message-ID: <20200128095929.tplg5if4mdkihheq@pengutronix.de> (raw)
In-Reply-To: <6607783.M6Blm0jaCt@n95hx1g2>
On Tue, Jan 28, 2020 at 10:39:10AM +0100, Christian Eggers wrote:
> Am Dienstag, 28. Januar 2020, 10:33:19 CET schrieb Sascha Hauer:
> > On Mon, Jan 27, 2020 at 08:46:06AM +0100, Christian Eggers wrote:
> > > The banner should already be printed, if CONFIG_COMPILE_LOGLEVEL is set
> > > to 5 (notice). If printing of the banner is not desired, CONFIG_BANNER
> > > can be disabled.
> >
> > With that argument you could put it in any loglevel you want to.
> that's right. Do you like to insert the highest possible log level for this
> particular case?
In that case we would get a big red "EMERG: barebox 2020..." message. I
just see that this already starts with pr_notice which now with this
patch prints "NOTICE: barebox 2020...". Hm, I don't think this is what
we want.
You probably have CONFIG_CONSOLE_ALLOW_COLOR disabled so you don't see
that.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-01-28 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 7:46 Christian Eggers
2020-01-28 9:33 ` Sascha Hauer
2020-01-28 9:39 ` [SPAM:54%] " Christian Eggers
2020-01-28 9:59 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128095929.tplg5if4mdkihheq@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ceggers@arri.de \
--cc=ceggers@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox