mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <ahmad@a3f.at>
To: barebox@lists.infradead.org
Subject: [PATCH] acpi: include missing header in <acpi.h>
Date: Mon,  3 Feb 2020 09:21:59 +0100	[thread overview]
Message-ID: <20200203082159.4455-1-ahmad@a3f.at> (raw)

acpi_sigcmp defined in the header uses memcmp, but no included headers
pull in memcmp, which can lead to compile errors in new code, depending
on include order. Fix this.

Reported-by: @healytpk, https://github.com/saschahauer/barebox/issues/7
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 include/acpi.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/acpi.h b/include/acpi.h
index 2d5fd3086a89..b8e73b35df99 100644
--- a/include/acpi.h
+++ b/include/acpi.h
@@ -6,6 +6,7 @@
 #ifndef __ACPI_H_
 #define __ACPI_H_
 
+#include <linux/string.h>
 #include <linux/types.h>
 #include <driver.h>
 
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2020-02-03  8:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03  8:21 Ahmad Fatoum [this message]
2020-02-10  8:08 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200203082159.4455-1-ahmad@a3f.at \
    --to=ahmad@a3f.at \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox