mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/3] commands/test: some improvements
Date: Tue, 4 Feb 2020 08:40:13 +0100	[thread overview]
Message-ID: <20200204074013.2pzg4y2okfcidpat@pengutronix.de> (raw)
In-Reply-To: <20200128130801.24890-1-u.kleine-koenig@pengutronix.de>

On Tue, Jan 28, 2020 at 02:07:58PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> my main intention was to implement -b and -c, the other two patches just
> fix some stuff I noticed while doing so.
> 
> One thing I noticed is that the check for
> 
> 	strlen(ap[1])
> 
> in the handling of -e and others is wrong.
> 
> This makes
> 
> 	test -e ''
> 
> return success, but
> 
> 	test -z something -o -e ''
> 
> fails. I don't know for sure how to fix this as the empty string might
> mean "." sometimes?
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (3):
>   commands/test: Bail out on incomplete command line options
>   commands/test: Improve option parsing to handle "]" less special
>   commands/test: Implement -b and -c to test for character and block
>     devices
> 
>  commands/test.c | 32 +++++++++++++++++++++++++++-----
>  1 file changed, 27 insertions(+), 5 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2020-02-04  7:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 13:07 Uwe Kleine-König
2020-01-28 13:07 ` [PATCH 1/3] commands/test: Bail out on incomplete command line options Uwe Kleine-König
2020-02-03  7:57   ` Sascha Hauer
2020-02-03  8:50     ` Uwe Kleine-König
2020-01-28 13:08 ` [PATCH 2/3] commands/test: Improve option parsing to handle "]" less special Uwe Kleine-König
2020-01-28 13:08 ` [PATCH 3/3] commands/test: Implement -b and -c to test for character and block devices Uwe Kleine-König
2020-02-04  7:40 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200204074013.2pzg4y2okfcidpat@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox