mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 6/8] led: pwm: fail if required max-brightness option is missing
Date: Thu,  6 Feb 2020 12:23:32 +0100	[thread overview]
Message-ID: <20200206112334.14314-7-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20200206112334.14314-1-a.fatoum@pengutronix.de>

If we leave max_value at the default value of zero led_pwm_set above
will divide by zero in do_div. The binding makes max-brightness
a mandatory property, so have the driver treat it as such as well.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/led/led-pwm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/led/led-pwm.c b/drivers/led/led-pwm.c
index 2b53614ed388..419d96eed392 100644
--- a/drivers/led/led-pwm.c
+++ b/drivers/led/led-pwm.c
@@ -61,7 +61,9 @@ static int led_pwm_of_probe(struct device_d *dev)
 		pwmled->led.name = xstrdup(child->name);
 		pwmled->pwm = pwm;
 
-		of_property_read_u32(child, "max-brightness", &pwmled->led.max_value);
+		ret = of_property_read_u32(child, "max-brightness", &pwmled->led.max_value);
+		if (ret)
+			return ret;
 
 		pwmled->period = pwm_get_period(pwmled->pwm);
 
-- 
2.25.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2020-02-06 11:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 11:23 [PATCH 0/8] PWM: misc fixes Ahmad Fatoum
2020-02-06 11:23 ` [PATCH 1/8] PWM: pxa: remove unused struct members Ahmad Fatoum
2020-02-06 11:23 ` [PATCH 2/8] PWM: pxa: make MMIO writes always little endian Ahmad Fatoum
2020-02-06 11:23 ` [PATCH 3/8] regmap: forward declare structs used in header Ahmad Fatoum
2020-02-06 11:23 ` [PATCH 4/8] video: backlight-pwm: remove duplicate assignment to object Ahmad Fatoum
2020-02-06 11:23 ` [PATCH 5/8] led: pwm: don't test if pointer is smaller than zero Ahmad Fatoum
2020-02-06 11:23 ` Ahmad Fatoum [this message]
2020-02-06 11:23 ` [PATCH 7/8] led: pwm: support active-low property Ahmad Fatoum
2020-02-06 11:23 ` [PATCH 8/8] PWM: core: constify chip->ops pointer Ahmad Fatoum
2020-02-10  8:16 ` [PATCH 0/8] PWM: misc fixes Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206112334.14314-7-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox