* [PATCH] acpi: include missing header in <acpi.h>
@ 2020-02-03 8:21 Ahmad Fatoum
2020-02-10 8:08 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2020-02-03 8:21 UTC (permalink / raw)
To: barebox
acpi_sigcmp defined in the header uses memcmp, but no included headers
pull in memcmp, which can lead to compile errors in new code, depending
on include order. Fix this.
Reported-by: @healytpk, https://github.com/saschahauer/barebox/issues/7
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
include/acpi.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/acpi.h b/include/acpi.h
index 2d5fd3086a89..b8e73b35df99 100644
--- a/include/acpi.h
+++ b/include/acpi.h
@@ -6,6 +6,7 @@
#ifndef __ACPI_H_
#define __ACPI_H_
+#include <linux/string.h>
#include <linux/types.h>
#include <driver.h>
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] acpi: include missing header in <acpi.h>
2020-02-03 8:21 [PATCH] acpi: include missing header in <acpi.h> Ahmad Fatoum
@ 2020-02-10 8:08 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-02-10 8:08 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Mon, Feb 03, 2020 at 09:21:59AM +0100, Ahmad Fatoum wrote:
> acpi_sigcmp defined in the header uses memcmp, but no included headers
> pull in memcmp, which can lead to compile errors in new code, depending
> on include order. Fix this.
>
> Reported-by: @healytpk, https://github.com/saschahauer/barebox/issues/7
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> include/acpi.h | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-10 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 8:21 [PATCH] acpi: include missing header in <acpi.h> Ahmad Fatoum
2020-02-10 8:08 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox